Sourcery Starbot ⭐ refactored radsn23/bandits-codes #1

sourcery-ai-bot · 2020-10-26T11:51:40Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/bandits-codes master
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai-bot · 2020-10-26T11:51:41Z

bandit_rl_implementations/ContextualBandits/CBThompsonSampling_LogisticReg.py

+	T = 500
+	N = 10 #number of batches
+	versions = 3 #or the number of arms of the bandit
+	l=0.1 #lambda
+	X_size = 3
 	for a in alphas:
-		T = 500
-		N = 10 #number of batches
-		versions = 3 #or the number of arms of the bandit
-		l=0.1 #lambda
-		X_size = 3


Lines 104-160 refactored with the following changes:

Hoist statements out of for/while loops (hoist-statement-from-loop)

sourcery-ai-bot · 2020-10-26T11:51:42Z

bandit_rl_implementations/EmailMAB/Bandits_email_version.py

-		if prior == None:
+		if prior is None:


Function email_mooclet.__init__ refactored with the following changes:

Use x is None rather than x == None (none-compare)

sourcery-ai-bot · 2020-10-26T11:51:42Z

bandit_rl_implementations/EmailMAB/Bandits_email_version.py

-tried_outputs = [0,0,0] 
+tried_outputs = [0,0,0]


Lines 41-62 refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai-bot · 2020-10-26T11:51:42Z

louie_experiments/LinUCB.py

-    # number of trials used to compute expectation stats
-    # set to small value when debugging for faster speed
-    num_trials_prob_best_action = int(1e4)
-
-    if models == None:
+    if models is None:


Function calculate_linucb_single_bandit refactored with the following changes:

Hoist statements out of for/while loops (hoist-statement-from-loop)

Move assignments closer to their usage (move-assign)

Use x is None rather than x == None (none-compare)

Replace index in for loop with direct reference (for-index-replacement)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai-bot · 2020-10-26T11:51:42Z

louie_experiments/data_reader.py

-    if len(pre_regret) == 0:
+    if not pre_regret:


Function read_avg_regret refactored with the following changes:

Simplify sequence comparison (simplify-len-comparison)

sourcery-ai-bot · 2020-10-26T11:51:44Z

louie_experiments/logistic_regression_scikit.py

-        pass
-
    plt.title(title)

    plt.show()

-    pass


Function plot_email_data refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai-bot · 2020-10-26T11:51:45Z

louie_experiments/queueBasedBandit.py

-        
+
        print(','.join(group_header), file=outf)

        writer = csv.DictWriter(outf, fieldnames=field_names_out)
        writer.writeheader()
-
-        sample_number = 0
+
        cumulative_sample_regret = 0
-        
-        for row in reader:
+
+        for sample_number, row in enumerate(reader):
            # copy the input data to output file
-            out_row = {}
+            out_row = {fieldname: row[fieldname] for fieldname in reader.fieldnames}

-            for i in range(len(reader.fieldnames)):
-                out_row[reader.fieldnames[i]] = row[reader.fieldnames[i]]
-
            ''' write performance data (e.g. regret) for this sample'''
            action = chosen_actions[sample_number]
            observed_rewards = [int(row[HEADER_ACTUALREWARD.format(a + 1)]) for a in range(num_actions)]
            sampling_dist = sampling_distributions[sample_number]
            reward = observed_rewards[action]
-                
+


Function writeOutFile refactored with the following changes:

Replace index in for loop with direct reference (for-index-replacement)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai-bot · 2020-10-26T11:51:45Z

louie_experiments/thompson_ng_policy.py

@@ -76,7 +76,6 @@ def write_performance(out_row, action, optimal_action, reward, sample_regret, cu
    out_row[H_ALGO_SAMPLE_REGRET_CUMULATIVE] = cumulative_sample_regret
    out_row[H_ALGO_REGRET_EXPECTED] = expected_regret
    out_row[H_ALGO_REGRET_EXPECTED_CUMULATIVE] = cumulative_expected_regret
-    pass


Function write_performance refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai-bot · 2020-10-26T11:51:45Z

louie_experiments/thompson_nig_policy.py

@@ -76,7 +76,6 @@ def write_performance(out_row, action, optimal_action, reward, sample_regret, cu
    out_row[H_ALGO_SAMPLE_REGRET_CUMULATIVE] = cumulative_sample_regret
    out_row[H_ALGO_REGRET_EXPECTED] = expected_regret
    out_row[H_ALGO_REGRET_EXPECTED_CUMULATIVE] = cumulative_expected_regret
-    pass


Function write_performance refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai-bot · 2020-10-26T11:51:45Z

louie_experiments/thompson_policy.py

@@ -66,7 +66,6 @@ def write_performance(out_row, action, optimal_action, reward, sample_regret, cu
    out_row[H_ALGO_SAMPLE_REGRET_CUMULATIVE] = cumulative_sample_regret
    out_row[H_ALGO_REGRET_EXPECTED] = expected_regret
    out_row[H_ALGO_REGRET_EXPECTED_CUMULATIVE] = cumulative_expected_regret
-    pass


Function write_performance refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai-bot · 2020-10-26T11:51:48Z

louie_experiments/thompson_policy.py

-    # number of trials used to run Thompson Sampling to compute expectation stats
-    # set to small value when debugging for faster speed
-    num_trials_prob_best_action = int(1e4)
-
-    if models == None:
+    if models is None:


Function calculate_thompson_single_bandit refactored with the following changes:

Move assignments closer to their usage (move-assign)

Use x is None rather than x == None (none-compare)

Replace index in for loop with direct reference (for-index-replacement)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

Convert for loop into dictionary comprehension (dict-comprehension)

'Refactored by Sourcery'

d523fcb

sourcery-ai-bot commented Oct 26, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery Starbot ⭐ refactored radsn23/bandits-codes #1

Sourcery Starbot ⭐ refactored radsn23/bandits-codes #1

sourcery-ai-bot commented Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

sourcery-ai-bot Oct 26, 2020

		tried_outputs = [0,0,0]
		tried_outputs = [0,0,0]

Sourcery Starbot ⭐ refactored radsn23/bandits-codes #1

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored radsn23/bandits-codes #1

Conversation

sourcery-ai-bot commented Oct 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment