Skip to content

Commit

Permalink
arm64: dts: radxa zero: remove dai-link-0 node
Browse files Browse the repository at this point in the history 
This patch aims to fix the issue of kernel complains:

    [   19.188742]  fe.dai-link-0: ASoC: no backend DAIs enabled for fe.dai-link-0

Signed-off-by: Stephen <stephen@vamrs.com>
  • Loading branch information
@StephenInVamrs
StephenInVamrs committed Nov 4, 2021
1 parent 775a467 commit fd159ba
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts
View file
Expand Up @@ -166,10 +166,6 @@
<393216000>;
status = "okay";

dai-link-0 {
sound-dai = <&frddr_a>;
};

dai-link-1 {
sound-dai = <&frddr_b>;
};
Expand Down

2 comments on commit fd159ba

@chewitt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether to laugh or cry at this change. The fe.dai-link-0: ASoC: no backend DAIs enabled for fe.dai-link-0 log spam is fixed by configuring mixer controls from userspace to complete the back-end audio routing. All this change does is prevent users from ever having working audio.

See https://github.com/chewitt/LibreELEC.tv/blob/amlogic/packages/audio/alsa-utils/scripts/soundconfig#L131-L175. You should be packaging something similar or restoring alsa control state in distro images. Have a look at what HardKernel does in their alsa userspace deb package.

@StephenInVamrs
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out this unreasonable commit. This commit will be removed.

Please sign in to comment.