Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pwm-fan and set default thermal policy to STEP_WISE #197

Closed
wants to merge 1 commit into from
Closed

Enable pwm-fan and set default thermal policy to STEP_WISE #197

wants to merge 1 commit into from

Conversation

hbiyik
Copy link

@hbiyik hbiyik commented Aug 29, 2023

This is necessary for rock5b pwm fan to operate

This is necessary for rock5b pwm fan to operate
@RadxaYuntian
Copy link
Member

This kernel and config file is shared with multiple products which may not include a fan, and even in case of 5B
the fan is an optional add-on. This is why the default thermal governor is power_allocator which operates passively.

pwm-fan is enabled globally in our bsp build script to ensure a consistent feature set across different kernel versions. It doesn't hurt to enable it here as well.

@hbiyik
Copy link
Author

hbiyik commented Aug 30, 2023

ok this means that i am building Archlinux kernels wrong. I was only using $BSP_DEFCONFIG, which is rockchip_linux_defconfig. But after analyzing your comment, i noticed that .common/kconfig.conf is merged with scripts/Kconfig/merge_config.sh merged on top of rockchip_linux_defconfig.

This should mean that .deb package of latest kernel which is rkr3.4 based should also have this enabled, is my understanding correct?

@RadxaYuntian
Copy link
Member

This is correct and we have working PWM fan support in 5A and 5B for a while.

@hbiyik
Copy link
Author

hbiyik commented Aug 30, 2023

ok then closing this PR, thanks for clearifactions..

@hbiyik hbiyik closed this Aug 30, 2023
@hbiyik hbiyik mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants