Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component Radzen Date Range Picker #1257

Closed
wants to merge 2 commits into from
Closed

New Component Radzen Date Range Picker #1257

wants to merge 2 commits into from

Conversation

SyedShahriyarAli
Copy link

@SyedShahriyarAli SyedShahriyarAli commented Nov 22, 2023

The Date Range Picker is an important component mostly used in reports or summaries. I have been using two RadzenDatePickers for date ranges for quite some time but I didn't like it much. Like the image below:

image

So I added a new component RadzenDateRangePicker, it has two calendars one for the Start Date and another for the End Date. It returns a class object RadzenDateRange having two attributes StartDate and EndDate. Most of the properties are similar to the RadzenDatePicker component.

I also added an example in 'DateRangePickerPage' for better understanding.

image

@enchev
Copy link
Collaborator

enchev commented Dec 6, 2023

Hi @SyedShahriyarAli,

Thank you very much for your pull request! We finally found time to check carefully your implementation since we will need to support it when merged and we've found that your code differs from our ideas for date range picker. For example we should have some internal component for rendering of the calendar in both current picker and the date range picker instead copy of the entire rendering in every component. The UI also should be different in our opinion, for example:
image
We are also unsure what's the best API for date range picker, is it value with array of dates or two properties for start/end date, etc. and because of these we've decided to not accept this pull request but rather create it in-house at some point.

@enchev enchev closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants