master build error fix, require go v1.11.4 or higher #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barisere
approved these changes
Jan 5, 2019
itswisdomagain
pushed a commit
that referenced
this pull request
Jan 9, 2019
master build error fix, require go v1.11.4 or higher Former-commit-id: b8bb928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building current source on master fails with the following transitive dependency fetch error:
The dependency
(github.com/mdp/qrterminal)that introduced that failing sub-dependency is removed in this PR. It was introduced recently in #54 to solve the problem of "huge" qrcode display on terminal.github.com/skip2/go-qrcodewas reintroduced to handle small qrcode printing on terminal. The current output with this PR is perhaps not as small as was achieved in #54 but certainly smaller than before #54:Also, this PR branch code was built with go v1.11.4 and the updated dependency checksums in
go.sumwill fail validation in previous go versions. The readme has been updated to reflect that only go v1.11.4 and higher can now be used to build this repo's code successfully.