implement dcrlibwallet get tx, improve same function for wallet rpc #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademuanthony
suggested changes
Jan 5, 2019
barisere
suggested changes
Jan 5, 2019
|
Block height now display with the latest versions of dcrd and dcrwallet. Transaction not found errors now show simpler error message: |
barisere
suggested changes
Jan 5, 2019
ademuanthony
approved these changes
Jan 5, 2019
barisere
approved these changes
Jan 5, 2019
itswisdomagain
pushed a commit
that referenced
this pull request
Jan 9, 2019
implement dcrlibwallet get tx, improve same function for wallet rpc Former-commit-id: bb1d833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of cli
show-transactionvia the updated rpc function or the newly implemented dcrlibwallet function. Major changes are addition of account name when displaying outputs and displaying block height instead of block hash. The block height is gotten using the block hash and since the blockhash is invalid (see #96), the block height is not currently found. A default value of -1 is displayed whenever the block hash cannot be used to get a matching block height.UPDATE:
dcrwallet rpc block hash issue is resolved, and block heights for transactions now display