Improve tab implementation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove Button from TabItem struct * display empty tab when no label defined * bug fix on adaptive tab size for bottom and right positions
oluwandabira
suggested changes
Apr 28, 2020
ui/decredmaterial/tabs.go
Outdated
| t.Flex.Spacing = layout.SpaceBetween | ||
| t.Flex.Layout(gtx, widgets...) | ||
| for i := range t.btns { | ||
| t.changed = false |
There was a problem hiding this comment.
This should be outside the for. I'm not sure why it worked before
ui/decredmaterial/tabs.go
Outdated
| } | ||
|
|
||
| widgets := t.contentTabPosition(gtx, body) | ||
| t.Flex.Spacing = layout.SpaceBetween |
There was a problem hiding this comment.
Unexport the Flex and set the spacing during the Tabs creation
ui/decredmaterial/tabs.go
Outdated
Comment on lines
192
to
193
| // contentTabPosition depending on the specified tab position determines the order of the tab and | ||
| // the page content. |
There was a problem hiding this comment.
Could you reword this?
ui/decredmaterial/tabs.go
Outdated
| ) | ||
| } | ||
|
|
||
| // Tabs lays out a Flexed(Size) List with Selected as the first element and Item as the rest. |
ui/decredmaterial/tabs.go
Outdated
Comment on lines
51
to
53
| // tabAlignment determines the alignment of the active tab indicator relative to the tab item | ||
| // content. It is determined by the position of the tab. | ||
| func indicatorDirection(tabPosition Position) layout.Direction { |
ui/decredmaterial/tabs.go
Outdated
| } | ||
| } | ||
|
|
||
| // indicator defines how the active tab indicator is drawn |
oshorefueled
force-pushed
the
improve-tab-73
branch
from
50d8eca
to
8bee469
Compare
oshorefueled
force-pushed
the
improve-tab-73
branch
from
f4cfd0c
to
473fa76
Compare
oshorefueled
force-pushed
the
improve-tab-73
branch
from
473fa76
to
5e6a63a
Compare
oshorefueled
force-pushed
the
improve-tab-73
branch
from
5e6a63a
to
271a91a
Compare
oluwandabira
suggested changes
May 1, 2020
| // scrollButton lays out the right and left scroll buttons of the tab when Position is Horizontal. | ||
| func (t *Tabs) scrollButton(gtx *layout.Context, right bool, button *widget.Button) layout.FlexChild { | ||
| show := false | ||
| icon := mustIcon(NewIcon(icons.NavigationChevronLeft)) |
There was a problem hiding this comment.
Decoding the icon should be done before the icon needs to be laid out and done only once.
| // Position determines what side of the page the tab would be laid out | ||
| type Position int | ||
|
|
||
| // TabItem displays a single child of a tab. Label and Icon in TabItem are optional. |
There was a problem hiding this comment.
If both Label and Icon are optional, what does it display when neither is present.
There was a problem hiding this comment.
Just tab items with the minimum width of the active indicator is displayed.
oluwandabira
approved these changes
May 4, 2020
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* add active indicator * add alignment option with no icon * add decred icons as bytes * add tab to wallet pages * make tab width and height adaptive * display empty tab when no label defined * add separator line to vertical tab * add navigation arrows for horizontal tab * add radius as optional to button widget
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Issue #73
What's new
This PR improves the current tab implementation by
Relevant screenshots or logs