feat: add bigquery export samples #7
Conversation
|
|
||
| package vtwo.bigquery; | ||
|
|
||
| // [START securitycenter_create_bigquery_export_v2] |
There was a problem hiding this comment.
This tag should enclose only the function public static void createBigQueryExport(, no?
There was a problem hiding this comment.
it makes sense if we follow the same example we used in GetIamPolicies:
https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/security-command-center/snippets/src/main/java/vtwo/iam/GetIamPolicies.java
but I'm worried about the change, as the same PR is already approved in the same syntax.
GoogleCloudPlatform#9291
| SecurityCenterClient client = mock(SecurityCenterClient.class); | ||
| try (MockedStatic<SecurityCenterClient> clientMock = Mockito.mockStatic( | ||
| SecurityCenterClient.class)) { | ||
| clientMock.when(SecurityCenterClient::create).thenReturn(client); |
There was a problem hiding this comment.
I guess these lines could be put in a @before method, once it's used in all of the tests.
| try (MockedStatic<SecurityCenterClient> clientMock = Mockito.mockStatic( | ||
| SecurityCenterClient.class)) { | ||
| clientMock.when(SecurityCenterClient::create).thenReturn(client); | ||
|
|
|
|
||
| // Define test data. | ||
| String filter = "test-filter"; | ||
|
|
| // Build the parent of the request. | ||
| OrganizationLocationName organizationName = OrganizationLocationName.of(ORGANIZATION_ID, | ||
| LOCATION); | ||
|
|
| .setFilter(filter) | ||
| .setDataset(String.format("projects/%s/datasets/%s", PROJECT_ID, BQ_DATASET_NAME)) | ||
| .build(); | ||
|
|
| .setBigQueryExport(expectedExport) | ||
| .setBigQueryExportId(BQ_EXPORT_ID) | ||
| .build(); | ||
|
|
| } | ||
|
|
||
| @Test | ||
| public void testDeleteBigQueryExport() throws IOException { |
There was a problem hiding this comment.
please do the same I asked for the first test on the tests below
| BQ_DATASET_NAME, BQ_EXPORT_ID); | ||
|
|
||
| // Verify that the createBigQueryExport method was called with the expected request. | ||
| Mockito.verify(client).createBigQueryExport(expectedRequest); |
There was a problem hiding this comment.
Please statically import Mockito.verify() so you can write this line as verify(client).createBigQueryExport(expectedRequest);
Same below!
| .build(); | ||
|
|
||
| // Mock the createBigQueryExport method to return the expected response. | ||
| Mockito.when(client.createBigQueryExport(any())).thenReturn(expectedExport); |
There was a problem hiding this comment.
Please statically import Mockito.when() so you can write this line as when(client.createBigQueryExport(any())).thenReturn(expectedExport);
|
|
||
| package vtwo.bigquery; | ||
|
|
||
| // [START securitycenter_create_bigquery_export_v2] |
| .build(); | ||
| // Mock the deleteBigQueryExport method to return successfully. | ||
| doNothing().when(client).deleteBigQueryExport(bigQueryExportRequest); | ||
| // Call the deleteBigQueryExport method. |
There was a problem hiding this comment.
Add line above, remember http://go/unit-testing-practices#structure
| doNothing().when(client).deleteBigQueryExport(bigQueryExportRequest); | ||
| // Call the deleteBigQueryExport method. | ||
| DeleteBigQueryExport.deleteBigQueryExport(ORGANIZATION_ID, LOCATION, BQ_EXPORT_ID); | ||
| // Verify that the deleteBigQueryExport method was called with the expected request. |
There was a problem hiding this comment.
Add line above, remember http://go/unit-testing-practices#structure
| SecurityCenterClient client = mock(SecurityCenterClient.class); | ||
| clientMock.when(SecurityCenterClient::create).thenReturn(client); |
There was a problem hiding this comment.
Can you also move these two lines to the setUp() method? (same for other methods)
There was a problem hiding this comment.
I found a way to move the two lines. The other attempts didn't work.
rafaelMurata
force-pushed
the
bigquery-samples-v2
branch
from
55085b4
to
8e9196e
Compare
rafaelMurata
force-pushed
the
bigquery-samples-v2
branch
from
8e9196e
to
280f187
Compare
…eleteBigQueryExport.java Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
…etBigQueryExport.java Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
…istBigQueryExports.java Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
…pdateBigQueryExport.java Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
rafaelMurata
force-pushed
the
bigquery-samples-v2
branch
from
9faabd1
to
433599c
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only