⌨️ change type structure of UseFormHandleSubmit (react-hook-form#11245

) * Change signature of UseFormHandleSubmit * add api-extractor report
rafaelcalhau · May 5, 2024 · 27bb083 · 27bb083
1 parent fc76251
commit 27bb083
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/reports/api-extractor.md b/reports/api-extractor.md
@@ -668,7 +668,7 @@ export type UseFormGetValues<TFieldValues extends FieldValues> = {
 };
 
 // @public
-export type UseFormHandleSubmit<TFieldValues extends FieldValues, TTransformedValues extends FieldValues | undefined = undefined> = (onValid: TTransformedValues extends FieldValues ? SubmitHandler<TTransformedValues> : SubmitHandler<TFieldValues>, onInvalid?: SubmitErrorHandler<TFieldValues>) => (e?: React_2.BaseSyntheticEvent) => Promise<void>;
+export type UseFormHandleSubmit<TFieldValues extends FieldValues, TTransformedValues extends FieldValues | undefined = undefined> = (onValid: TTransformedValues extends undefined ? SubmitHandler<TFieldValues> : TTransformedValues extends FieldValues ? SubmitHandler<TTransformedValues> : never, onInvalid?: SubmitErrorHandler<TFieldValues>) => (e?: React_2.BaseSyntheticEvent) => Promise<void>;
 
 // @public (undocumented)
 export type UseFormProps<TFieldValues extends FieldValues = FieldValues, TContext = any> = Partial<{

diff --git a/src/types/form.ts b/src/types/form.ts
@@ -623,9 +623,11 @@ export type UseFormHandleSubmit<
   TFieldValues extends FieldValues,
   TTransformedValues extends FieldValues | undefined = undefined,
 > = (
-  onValid: TTransformedValues extends FieldValues
+  onValid: TTransformedValues extends undefined
+    ? SubmitHandler<TFieldValues>
+    : TTransformedValues extends FieldValues
     ? SubmitHandler<TTransformedValues>
-    : SubmitHandler<TFieldValues>,
+    : never,
   onInvalid?: SubmitErrorHandler<TFieldValues>,
 ) => (e?: React.BaseSyntheticEvent) => Promise<void>;