Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

This commit refactors the crate to decouple it from diesel_async #6

Merged

Conversation

weiznich
Copy link
Contributor

This makes it possible to provide custom implementations of TaskStore outside of backie (for example for sync diesel connections and other backend types)

I've put everything diesel_async specific behind a feature flag that is enabled by default. The public API with that feature flag enabled stays mostly the same as demonstrated by the example. Only the enqueue function now needs to know about a specific task store to determine the backend type.

My use case for this is using backie with other diesel connections as well

This makes it possible to provide custom implementations of `TaskStore` outside of backie (for
example for sync diesel connections and other backend types)

I've put everything diesel_async specific behind a feature flag that is
enabled by default. The public API with that feature flag enabled stays
mostly the same as demonstrated by the example. Only the `enqueue`
function now needs to know about a specific task store to determine the
backend type.
Copy link
Owner

@rafaelcaricio rafaelcaricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to do this, but I didn't manage to find a way. Thank you for this work. Also, many thanks for the Diesel project! <3

@rafaelcaricio
Copy link
Owner

@weiznich would you mind fixing those Clippy errors?

@weiznich
Copy link
Contributor Author

I've pushed an update to fix the test failures.

@rafaelcaricio rafaelcaricio merged commit 11b3400 into rafaelcaricio:main Jul 12, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants