Revise middleware deletion #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this branch uses the deleted location, not the new location.
1. insertions relative to deleted middleware should operate according to the location of the deleted middleware as if the middleware had never been deleted. 2. deleting a middleware should delete all instances of it in the stack (this is current Rails behavior, but former commits in this tree changed it)
1. inserting relative to a deleted middleware should act as if the middleware had not been deleted 2. deleting a middleware should delete all instances of it in the stack
Formerly this was only being tested for `use`. Now, it's being tested for `use`, `insert`, `insert_before`, `insert_after`, `swap`, and `unshift` Since I changed some of the code affecting this, it seemed prudent to add more thorough coverage.
|
This also addresses rails#27936 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested addendum to rails#27936
Specifically it addresses the issue mentioned here: rails#27936 (comment)
It also restores previous behavior so that deleting a middleware deletes all instances of the middleware in the stack, rather than just the first one.