Endless Scrolling: fix bug that does not sort giveaways across multiple pages

[Thexder0]

When sorting by Rating, each page is sorted, but the algorithm does not sort across multiple pages.

Steps to Reproduce

1. Activate Endless Scrolling
2. Let a couple pages load
3. Click on "Sort (Rating -- Descending)"

Expected Behavior
The expected behaviour was to have all GAs sorted by rating, independently of the page they came from.

Console Errors
None.

System (please complete the following information):

• ESGST Version: 8.3.3
• Browser + Version: Chrome v73

Additional Context
Just want to add: thank you for this fantastic add-on! This bug is absolutely not urgent, we can totally live without Sort by Rating across multiple pages, of course! Thank you!

Screenshot
This shows the GAs of two consecutive pages, AFTER sorting by rating. Turbo Pug is the first GA in the next page.

[Thexder0]

Hm, sorry to say, but this is still not working for "Ratings"... When I sort by name, it does sort across pages, but for some reason "Sort by Rating" is still kind of crazy.

Once again, thank you for all the work, the add-on is amazing!

Cheers!

Edit: not sure how I can reopen this "Issue", so to speak -- should I start a new thread?

[rafaelgomesxyz]

It's working fine for me. Did you wait until all categories were loaded? The filters only kick in after all ratings have been loaded for all giveaways in the page. Try loading the page and waiting a bit to see if it sorts itself.

[Thexder0]

Hm, let me see...

Ok, I did some further experiments. I use the filter "Entered = FALSE" in almost all SG pages I visit. With this, the sorting DOES NOT work for me (it looks like that screenshot I posted a while ago).

However: if remove this filter, yes, the feature works beautifully, across pages and all! So it must be some sort of interaction between the sorting and this filter? Maybe the problem is not the page breaks, but somehow the sorting gets lost when it finds a filtered GA?

Anyway, if you want to debug this and I can help more, let me know.

Cheers (and thanks)!

[rafaelgomesxyz]

Sorry, I still cannot reproduce it, so I'm going to need your settings, if you can share them. Make sure to download them through the "Download settings" button, because if you download them through the backup menu, it will contain your personal information.

[Thexder0]

Ok, see if this helps somehow. Cheers!

…

On Sun, May 26, 2019 at 1:36 PM Rafael ***@***.***> wrote: Sorry, I still cannot reproduce it, so I'm going to need your settings, if you can share them. Make sure to download them from the "Download settings" button, because if you download it through the backup menu, it will contain your personal information. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6C5TXZSONLHIXF2CQGTA3PXK4BJANCNFSM4HE6ZN5Q> .

[Thexder0]

P.S.: Hold on, you do have access to the E-mail attachment, right?

…

On Sun, May 26, 2019 at 3:23 PM Ralph Teixeira ***@***.***> wrote: Ok, see if this helps somehow. Cheers! On Sun, May 26, 2019 at 1:36 PM Rafael ***@***.***> wrote: > Sorry, I still cannot reproduce it, so I'm going to need your settings, > if you can share them. Make sure to download them from the "Download > settings" button, because if you download it through the backup menu, it > will contain your personal information. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#1276>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AF6C5TXZSONLHIXF2CQGTA3PXK4BJANCNFSM4HE6ZN5Q> > . >

[rafaelgomesxyz]

Yes, thanks.

[rafaelgomesxyz]

Alright, sorry it took this long, I can reproduce now with your settings. Will try to fix for the next version.

[Thexder0]

No need to be sorry, as I have always said, your add-on is superb, it works beautifully, we are all very thankful for it, and this particular bug was very very minor. That said -- I am glad you managed to find the bug and squash it (hopefully?). Thank you once again! Cheers!

…

On Thu, Jun 27, 2019 at 11:53 PM Rafael ***@***.***> wrote: Alright, sorry it took this long, I can reproduce now with your settings. Will try to fix for the next version. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1276>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF6C5TSQCIT6FBB2FY7327TP4V4JJANCNFSM4HE6ZN5Q> .