Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsent Gift Sender: do not send to profiles that couldn't be checked if the option to check the rules is enabled #1386

Closed
at46 opened this issue Jun 2, 2019 · 1 comment
Milestone

Comments

@at46
Copy link

at46 commented Jun 2, 2019

Is your enhancement request related to a problem? Please describe.
I like to use Unsent Gift Sender especially when I have multiple giveaways to send. I use the "Do not send if the winner has any not activated/multiple wins." option because I want to check those myself and sometimes ask for a reroll. Unfortunately the feature sends the key also to users whose profiles cannot be checked because e.g. they're private. I would like to have an option to not send the key in such cases. These are uncommon and while you cannot check them yourself you can ask support to check them.

Describe the solution you'd like.
Add an option to not send keys to profiles which couldn't get checked

Describe alternatives you've considered.
I can check the winners before and only use unsent gift sender afterwards to send the keys. Or use the feature, search for winners which couldn't get checked and unsent the key. But both alternatives mean more manual work.

@rafaelgomesxyz
Copy link
Owner

Doesn't make sense to add it as an option for me (why would anyone want to send for private profiles if they only want to send to winners who didn't break the rules?), so I'll add it as the default behavior.

@rafaelgomesxyz rafaelgomesxyz added this to the 8.3.16 milestone Jun 21, 2019
@rafaelgomesxyz rafaelgomesxyz changed the title Unsent Gift Sender add option for profiles which couldn't get checked Unsent Gift Sender: do not send to profiles that couldn't be checked if the option to check the rules is enabled Jun 21, 2019
rafaelgomesxyz pushed a commit that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants