-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: improve menu design #1400
Comments
I decided to add the collapse button to all settings, but make it faded and not clickable for settings that don't have sub-settings. This allows for the settings to be positioned the way you requested. Let me know if this is a good solution for you. |
It's a quick solution that works. Maybe make it the same gray as the menu background to completely hide them? Though then the vertical lines are broken... |
Don't know where your comment went, but I got it via Email. So in regards of poeple (not) getting it: Sure, people should get it. But faded out typically doesn't mean there's nothing but rather that the option is currently not available. And with the vast amount of options, people might think there's settings but they can't reach them right now, possibly triggering them to make issue reports about missing options. |
I deleted it because I decided to just re-position them (commit above). |
I see, though I assumed this was not as quickly done as you wanted to insert the pluses instead. |
Looks good after the changes! |
Is your enhancement request related to a problem? Please describe.
For better/quicker readability when searching for specific settings and just in general for better readability, the indentation of (sub-)settings should be bigger in order to have settings of the same level directly one below the other.
Unfortunately, when there's sub-settings to a setting, the plus signs are pushing the numbering to the right, almost to where numbering of sub-sub-settings start.
Describe the solution you'd like.
By increasing the space horizontally between main and sub-settings readability can be increased.
Additional Info
The red line shows the beginning of the setting categories. The blue lines both show where settings of the first level start, the green line show where sub-settings (second level) start.
In the screenshot you can see, that the second blue line almost touches the green one, therefore making settings seem to be part of sub-settings.
Same issue for the next deeper level (not marked in screenshot, e.g. 1.6.3 "Giveaway Groups" and 1.6.3.1 "Only show groups that you are a member of").
The text was updated successfully, but these errors were encountered: