Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all callback functions into promises and use async/await to deal with them #353

Closed
rafaelgomesxyz opened this issue Dec 31, 2017 · 4 comments
Closed

Convert all callback functions into promises and use async/await to deal with them #353

rafaelgomesxyz opened this issue Dec 31, 2017 · 4 comments
Labels
Enhancement Work In Progress

Comments

@rafaelgomesxyz
Copy link
Owner

This will make the code much cleaner and should also improve performance.
@rafaelgomesxyz rafaelgomesxyz changed the title Convert all callback functions in the script into promises and use async/await to deal with them Convert all callback functions into promises and use async/await to deal with them Dec 31, 2017
rafaelgomesxyz pushed a commit that referenced this issue Jan 1, 2018
#353 Convert all callback functions into promises and use async/await…
483707c 
… to deal with them
@rafaelgomesxyz rafaelgomesxyz added this to the 7.12.1 milestone Jan 1, 2018
@rafaelgomesxyz rafaelgomesxyz mentioned this issue Jan 2, 2018
Closed
rafaelgomesxyz pushed a commit that referenced this issue Jan 2, 2018
#353
4e17aa7
@rafaelgomesxyz rafaelgomesxyz mentioned this issue Jan 3, 2018
Closed
rafaelgomesxyz pushed a commit that referenced this issue Jan 5, 2018
#353
38ad5f1
rafaelgomesxyz pushed a commit that referenced this issue Jan 6, 2018
#353
1a936e0
@rafaelgomesxyz rafaelgomesxyz modified the milestones: 7.12.1, 7.12.2 Jan 7, 2018
rafaelgomesxyz pushed a commit that referenced this issue Jan 7, 2018
#353
a4a5fe3
rafaelgomesxyz pushed a commit that referenced this issue Jan 9, 2018
#353
90cc94f
@rafaelgomesxyz rafaelgomesxyz modified the milestones: 7.12.2, 7.12.3 Jan 9, 2018
@rafaelgomesxyz rafaelgomesxyz mentioned this issue Jan 12, 2018
Closed
@rafaelgomesxyz rafaelgomesxyz modified the milestones: 7.13.0, 7.13.1 Jan 13, 2018
rafaelgomesxyz pushed a commit that referenced this issue Jan 13, 2018
#353
ec46978
rafaelgomesxyz pushed a commit that referenced this issue Jan 24, 2018
#353
fba9db5
@rafaelgomesxyz rafaelgomesxyz modified the milestones: 7.13.1, 7.14.0 Feb 3, 2018
rafaelgomesxyz pushed a commit that referenced this issue Feb 4, 2018
v7.14.2 (Dev.12) #353
ab3b824
@gizellos
Copy link

gizellos commented Feb 5, 2018

Do you have to rewrite all the script because of it?

@rafaelgomesxyz
Copy link
Owner Author

Yes

@gizellos
Copy link

gizellos commented Feb 5, 2018

Please explain me what it does.

@rafaelgomesxyz
Copy link
Owner Author

Like I said in the first comment it should make the code cleaner and improve performance. But I'm also doing a lot of other improvements in this issue.

rafaelgomesxyz pushed a commit that referenced this issue Feb 8, 2018
v7.14.3 (Dev.4) #353
d5c0882
rafaelgomesxyz pushed a commit that referenced this issue Mar 4, 2018
v7.16.5 (Dev.4) #353
88c9914
@rafaelgomesxyz rafaelgomesxyz removed this from the 7.14.0 milestone Mar 4, 2018
@rafaelgomesxyz rafaelgomesxyz added this to the 7.16.2 milestone Mar 4, 2018
@rafaelgomesxyz rafaelgomesxyz removed this from the 7.16.5 milestone Mar 29, 2018
rafaelgomesxyz pushed a commit that referenced this issue May 23, 2018
7.19.1 (Dev.10) #353
8156462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Work In Progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gizellos @rafaelgomesxyz