Store package in response instead of the path

With the package in the response we can update it more easily depending on the result data.
rafaeljusto · Oct 29, 2015 · be1b62b · be1b62b
1 parent 1359dca
commit be1b62b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/cmd/gddoexp/gddoexp.go b/cmd/gddoexp/gddoexp.go
@@ -91,9 +91,9 @@ func main() {
 		if response.Error != nil {
 			log.Println(response.Error)
 		} else if response.Suppress {
-			log.Printf("package “%s” should be suppressed\n", response.Path)
+			log.Printf("package “%s” should be suppressed\n", response.Package.Path)
 			if progress != nil && !*progress {
-				fmt.Println(response.Path)
+				fmt.Println(response.Package.Path)
 			}
 		}
 	}

diff --git a/gddoexp.go b/gddoexp.go
@@ -32,7 +32,7 @@ type gddoDB interface {
 // SuppressResponse stores the information of a path verification on an
 // asynchronous check.
 type SuppressResponse struct {
-	Path     string
+	Package  database.Package
 	Suppress bool
 	Cache    bool
 	Error    error
@@ -97,7 +97,7 @@ func ShouldSuppressPackages(packages []database.Package, db gddoDB, auth *Github
 				for p := range in {
 					suppress, cache, err := ShouldSuppressPackage(p, db, auth)
 					out <- SuppressResponse{
-						Path:     p.Path,
+						Package:  p,
 						Suppress: suppress,
 						Cache:    cache,
 						Error:    err,

diff --git a/gddoexp_test.go b/gddoexp_test.go
@@ -448,23 +448,23 @@ func TestShouldSuppressPackages(t *testing.T) {
 			},
 			expected: []gddoexp.SuppressResponse{
 				{
-					Path:     "github.com/docker/docker",
+					Package:  database.Package{Path: "github.com/docker/docker"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/golang/gddo",
+					Package:  database.Package{Path: "github.com/golang/gddo"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/golang/go",
+					Package:  database.Package{Path: "github.com/golang/go"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/miekg/dns",
+					Package:  database.Package{Path: "github.com/miekg/dns"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/rafaeljusto/gddoexp",
+					Package:  database.Package{Path: "github.com/rafaeljusto/gddoexp"},
 					Suppress: true,
 				},
 			},
@@ -509,23 +509,23 @@ func TestShouldSuppressPackages(t *testing.T) {
 			},
 			expected: []gddoexp.SuppressResponse{
 				{
-					Path:     "github.com/docker/docker",
+					Package:  database.Package{Path: "github.com/docker/docker"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/golang/gddo",
+					Package:  database.Package{Path: "github.com/golang/gddo"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/golang/go",
+					Package:  database.Package{Path: "github.com/golang/go"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/miekg/dns",
+					Package:  database.Package{Path: "github.com/miekg/dns"},
 					Suppress: true,
 				},
 				{
-					Path:     "github.com/rafaeljusto/gddoexp",
+					Package:  database.Package{Path: "github.com/rafaeljusto/gddoexp"},
 					Suppress: true,
 				},
 			},
@@ -563,27 +563,27 @@ func TestShouldSuppressPackages(t *testing.T) {
 			},
 			expected: []gddoexp.SuppressResponse{
 				{
-					Path:     "github.com/docker/docker",
+					Package:  database.Package{Path: "github.com/docker/docker"},
 					Suppress: true,
 					Cache:    true,
 				},
 				{
-					Path:     "github.com/golang/gddo",
+					Package:  database.Package{Path: "github.com/golang/gddo"},
 					Suppress: true,
 					Cache:    true,
 				},
 				{
-					Path:     "github.com/golang/go",
+					Package:  database.Package{Path: "github.com/golang/go"},
 					Suppress: true,
 					Cache:    true,
 				},
 				{
-					Path:     "github.com/miekg/dns",
+					Package:  database.Package{Path: "github.com/miekg/dns"},
 					Suppress: true,
 					Cache:    true,
 				},
 				{
-					Path:     "github.com/rafaeljusto/gddoexp",
+					Package:  database.Package{Path: "github.com/rafaeljusto/gddoexp"},
 					Suppress: true,
 					Cache:    true,
 				},
@@ -1229,7 +1229,7 @@ type bySuppressResponsePath []gddoexp.SuppressResponse
 
 func (b bySuppressResponsePath) Len() int           { return len(b) }
 func (b bySuppressResponsePath) Swap(i, j int)      { b[i], b[j] = b[j], b[i] }
-func (b bySuppressResponsePath) Less(i, j int) bool { return b[i].Path < b[j].Path }
+func (b bySuppressResponsePath) Less(i, j int) bool { return b[i].Package.Path < b[j].Package.Path }
 
 type byFastForkResponsePath []gddoexp.FastForkResponse