Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tray icon to access the app rapidly when closed but running #44

Closed
Porrumentzio opened this issue Sep 12, 2020 · 25 comments
Closed
Labels
wontfix This will not be worked on

Comments

@Porrumentzio
Copy link
Contributor

Since the sound can still be played when closed the app, what I lack is rapid way to access to it (instead of going to the system menu, search for it and opening) to change sound levels.

I think that this would be good solution to this. What do you think?

@rafaelmardojai
Copy link
Owner

rafaelmardojai commented Sep 12, 2020

You should be able to open the app by clicking somewhere in the MPRIS integration.

If you can't, you should report it to your desktop. I don't know how MATE handles this.

@Porrumentzio
Copy link
Contributor Author

Is it supposed that with MPRIS integration there should be a tray icon? I don't really now how it works 😅

@rafaelmardojai
Copy link
Owner

It depends on your desktop.

GNOME for example, integrates MPRIS with a banner in the notification area, here's Blanket and a music player:
Captura de pantalla de 2020-09-12 11-27-07
If you click the banner the app will show up.

I think KDE adds an icon in the panel, and so on.
But I don't know how MATE integrates MPRIS.

@Porrumentzio
Copy link
Contributor Author

Understood. So definitively, it's not like that, and the app can't be opened by clicking.

@rafaelmardojai
Copy link
Owner

How looks the indicator to you in MATE?

@Porrumentzio
Copy link
Contributor Author

I even don't now if there is such thing. The most similar is the sound-control panel.

@rafaelmardojai
Copy link
Owner

You don't have media controls in MATE?

@Porrumentzio
Copy link
Contributor Author

Seems that not, I didn't find anything like that.

@rafaelmardojai
Copy link
Owner

Doesn't MATE has MPRIS controls in the volume indicator?

@Porrumentzio
Copy link
Contributor Author

This maybe:
irudia

@rafaelmardojai
Copy link
Owner

Nothing like this in the panels?
1UZHe

@Porrumentzio
Copy link
Contributor Author

Nope. When Audacious playing, right click on its tray icons allows to pause/play and so on; left click opens the app.

@rafaelmardojai
Copy link
Owner

Nope. When Audacious playing, right click on its tray icons allows to pause/play and so on; left click opens the app.

That sounds like Audacious builtin systray. Strange to know that MATE doesn't have MPRIS support.

@apandada1 how does it play in Cinnamon?

@Porrumentzio
Copy link
Contributor Author

This is the only what I have found:
msd-mpris-manager.c

MATE is a fork of GNOME2

@rafaelmardojai
Copy link
Owner

MATE is a fork of GNOME2

I know, but i thought they were using old Ubuntu's indicator-sound or something.

@archisman-panigrahi
Copy link
Contributor

@apandada1 how does it play in Cinnamon?

It plays correctly even after closing the app. It shows up in the volume indicator, and can be controlled with laptop's function keys. And, the app can again be opened quickly, by clicking the ⬆️ button in the sound applet.

Screenshot from 2020-09-13 07-56-47

@rafaelmardojai
Copy link
Owner

rafaelmardojai commented Sep 13, 2020

I'm closing this as a wontfix for the systray. I think MPRIS is enough for our needs, and widely supported (GNOME, KDE, Xfce, Cinnamon, etc.).

@Porrumentzio probably you can find some extension/applet for MATE that provides better MPRIS support. But researching looks like MATE already have decent support, so i don't know if is a fact of the Manjaro implementation.

@rafaelmardojai rafaelmardojai added the wontfix This will not be worked on label Sep 13, 2020
@haggen88
Copy link
Contributor

haggen88 commented Sep 21, 2020

@rafaelmardojai a query. Is there a whiter version of the Blanket symbolic icon?.
At the moment in Cinnamon [Mint 20] it looks like this:

MB

@Porrumentzio
Copy link
Contributor Author

This is the new one since 2020/09/21
irudia

@rafaelmardojai
Copy link
Owner

This is the new one since 2020/09/21

Not really, @haggen88 is getting the icon for pulseaudio, which don't have white borders.

If the icon is symbolic the DE should be able to turn it white like GNOME shell.

Captura de pantalla de 2020-09-21 10-16-24

Captura de pantalla de 2020-09-21 10-17-01

@ashishbinu
Copy link

I don't get systray in kde.Is that bug in the software.I get systray for various other applications like flameshot, ulauncher, mailspring,etc.

Systray

@archisman-panigrahi
Copy link
Contributor

@ashishbinu This is KDE issue is probably a duplicate of #96 (Blanket does not register itself as a media playing application in KDE). Do the play/pause buttons work for you?

@ashishbinu
Copy link

ashishbinu commented May 19, 2021

Do the play/pause buttons work for you?

@apandada1 There is no play/pause button in my system if the windows is closed by ctrl+w.I can only mute the sound using volume control of blanket in my panel.

But having a systray to open the closed blanket window, having a play/pause button, a quit button would be good feature. Is someone working on issue #96 .

@archisman-panigrahi
Copy link
Contributor

archisman-panigrahi commented May 19, 2021

There is no play/pause button in my system if the windows is closed by ctrl+w.I can only mute the sound using volume control of blanket in my panel.

I was referring to the media control buttons of a laptop. The play/pause button in the CSD headerbar work perfectly on KDE.
When Blanket is minimized, there will be a way to play/pause once #96 is fixed. Other media players (e.g. VLC, lollypop) can be played and paused within KDE's sound applet. Blanket somehow cannot register itself as a media player in KDE.

@Porrumentzio
Copy link
Contributor Author

@ashishbinu, just what you ask for was asked before and rejected, see #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants