Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 Sounds #50

Closed
8 of 22 tasks
rafaelmardojai opened this issue Sep 18, 2020 · 34 comments
Closed
8 of 22 tasks

4.0 Sounds #50

rafaelmardojai opened this issue Sep 18, 2020 · 34 comments
Milestone

Comments

@rafaelmardojai
Copy link
Owner

rafaelmardojai commented Sep 18, 2020

New sounds

Nature

Travel

Noise

  • Brown (Red) Noise

Icons

  • Waves
  • Birds
  • Stream
  • Train
  • Boat
  • City
  • Brown Noise

Sound improvements

@rafaelmardojai rafaelmardojai added this to the 0.4.0 milestone Sep 18, 2020
@rafaelmardojai
Copy link
Owner Author

cc @Porrumentzio

@rafaelmardojai
Copy link
Owner Author

@Porrumentzio any suggestions on what category use for Train? Should we change nature/interiors to outdoors/indoors?

@Porrumentzio
Copy link
Contributor

I think Nature will be more understandable than outdoors, so I would let it that way. I think we could add some category such as Civilized or something that way, to say that it has been changed by humans, but Coffee Shop is ambiguous between Interiors and Civilized

What do you think? And @haggen88?

@rafaelmardojai
Copy link
Owner Author

What about Civilization? And Fireplace could go in there since is a civilized fire? 🤣

@haggen88
Copy link
Contributor

IMHO the train sound is recorded from inside the locomotive, even though it is moving outside [it is not a passing train].
It is necessary to see which criterion has more weight to define the sounds.
ex. They can be defined according to:
A) who / what produces them [natural / artificial-human]
B) the distance from the emitting source [near / interior - far / exterior].

@Porrumentzio
Copy link
Contributor

Could be 😆 Doesn't uncivilized cultures make fire? Or is it so clear that that fire is in a chimney fireplace?

@Porrumentzio
Copy link
Contributor

I think that is more understandable to have an object-centred view of sounds, because our minds in current culture thought that way, not depending on the subject.
So I think that option A, sound source, will be more comprehensible.

@haggen88
Copy link
Contributor

haggen88 commented Sep 19, 2020

@Porrumentzio @rafaelmardojai

What is civilized or uncivilized is more complex [depending on who defines the level of culture]. Perhaps another selection criterion could be according to the mobility of the environment [static - in transit].

Perhaps a category of in transit / travel is easier to understand. Maybe in the future more sounds can be added such as boat or car travel [or car traffic / soft city noise]. Some examples:

@Porrumentzio
Copy link
Contributor

That's good. Something as Travel or Transport would be good I think

@Porrumentzio
Copy link
Contributor

What about writing down somewhere the possible future sounds? That way we could add them by groups and more organizedly

@rafaelmardojai
Copy link
Owner Author

Perhaps a category of in transit/travel is easier to understand. Maybe in the future more sounds can be added such as boat or car travel [or car traffic / soft city noise].

Yeah, that looks good.

But, what I don't want is the sound catalog to be very large. Currently we have 9 sounds (removing noise sounds that will be generated) witch are 13,5 Mb. We need to put a limit on how much this could grow.

Probably later we can create an extended online catalog of curated sounds, and users can download those sounds inside the app.

@Porrumentzio
Copy link
Contributor

It has something to see the length of files. Does the app cycle through all the length of each file or does only take a piece of it?

If the second case, the sound comfortability will decrease but the files could be cut.

@rafaelmardojai
Copy link
Owner Author

It has something to see the length of files. Does the app cycle through all the length of each file or does only take a piece of it?

The app loop the whole audio file.

@Porrumentzio
Copy link
Contributor

Okay, so it would be good to put a limit of disk, although I don't really understand the reason.

Other possibility would be to work with plugin-packages: travel-sounds-blanket, nature-sounds-blanket and so on. This way the main app would be lightweight but it would be easy to add more sounds (an announcement about this in the app would be great for users)

@haggen88
Copy link
Contributor

haggen88 commented Sep 19, 2020

Yeah, that looks good.

But, what I don't want is the sound catalog to be very large. Currently we have 9 sounds (removing noise sounds that will be generated) witch are 13,5 Mb. We need to put a limit on how much this could grow.

Probably later we can create an extended online catalog of curated sounds, and users can download those sounds inside the app.

Personally, I would leave this new category with only 3 sounds:

In that case there would be a catalog of 13 sounds [if pink and white noise are not eliminated]. What do you think @Porrumentzio @rafaelmardojai ?

@rafaelmardojai
Copy link
Owner Author

  • boat: Ambience Sea Boat Night Ropes - 1 and 4.zip
  • light traffic / street sounds: ny streets.zip

I'm fine about adding those. We don't want the new Transport category to have one sound.

Okay, so it would be good to put a limit of disk, although I don't really understand the reason.

I just don't want to bloat users with a lot of sounds that they are not going to use. We should ship the sounds that people expect in this kind of program.

Other possibility would be to work with plugin-packages: travel-sounds-blanket, nature-sounds-blanket and so on. This way the main app would be lightweight but it would be easy to add more sounds (an announcement about this in the app would be great for users)

Yeah, that is another option. But having an online catalog allows us to add new sounds without releasing new versions.

@Porrumentzio
Copy link
Contributor

No matter the how, it's okay :)
I'll have a look to new sounds.

@haggen88
Copy link
Contributor

I have a doubt ... does the reproduction of the current loop of the sounds have some kind of crosfade? Or are the sound clips edited in such a way as to make the sounds more "continuous" and without volume drops / silences?.

@Porrumentzio
Copy link
Contributor

They have not such a think AFAIK. Most sounds coincide that the beginning and ending are similar and match. I'm just gonna change the new rain clip because the loop limit is noticeable.

Do you dislike that?

@rafaelmardojai
Copy link
Owner Author

light traffic / street sounds could be named City Trafic or simply Street.

I have a doubt ... does the reproduction of the current loop of the sounds have some kind of crosfade? Or are the sound clips edited in such a way as to make the sounds more "continuous" and without volume drops / silences?.

When I created the app, edited some sounds to avoid gaps when looping.

@Porrumentzio
Copy link
Contributor

By the way, @haggen88, could you add the links to those new transport sounds please?

@haggen88
Copy link
Contributor

haggen88 commented Sep 20, 2020

They have not such a think AFAIK. Most sounds coincide that the beginning and ending are similar and match. I'm just gonna change the new rain clip because the loop limit is noticeable.

Do you dislike that?

It is just an appreciation. I downloaded the sounds from the web that I proposed and some have small gaps that can be improved. It's nothing really serious.

By the way, @haggen88, could you add the links to those new transport sounds please?

@Porrumentzio
Copy link
Contributor

Thanks for the links @haggen88! The clips are edited to fit in the loop.

@rafaelmardojai, what about City for the NY street sound?

@rafaelmardojai
Copy link
Owner Author

rafaelmardojai commented Sep 20, 2020

what about City for the NY street sound?

City and Street fits perfect for that sound. But I prefer Street as personal taste.

@Porrumentzio
Copy link
Contributor

It doesn't really matter to me. For me City is more accurate, because the streets on my tiny village doesn't sound that way, but only those of cities 😅🤣

@rafaelmardojai
Copy link
Owner Author

You got a point. Let's go with City.

rafaelmardojai added a commit that referenced this issue Sep 20, 2020
@rafaelmardojai
Copy link
Owner Author

rafaelmardojai commented Sep 20, 2020

Just added the new sounds to the UI. I need to get some free time to work on icons.

@Porrumentzio
Copy link
Contributor

I'm testing them. Test by yourself too and say if the level is okay. Seems to me that the volume is maybe a bit low, but maybe that's because before they were too loud.

@rafaelmardojai
Copy link
Owner Author

Overall sounds good to me.

The only detail is that the new rain is too soft for what I'm used 😅️, but not a real issue.

@Porrumentzio
Copy link
Contributor

It's possible that it's due to the new has a greater range (the perception is a lower volume). We'll have to test and test since have a good level of each sound, this is more a subjective issue than a mathematic.

So use it more and if in three days of use it's still too low, I'll change it :)

@rafaelmardojai
Copy link
Owner Author

It's possible that it's due to the new has a greater range (the perception is a lower volume). We'll have to test and test since have a good level of each sound, this is more a subjective issue than a mathematic.

Technically is fine. The issue is that I live in rain forest, and rain sometimes doesn't sounds like that 😂

@Porrumentzio
Copy link
Contributor

We should so name that sound as "Non-rainforest Rain" 😉

@haggen88
Copy link
Contributor

haggen88 commented Sep 28, 2020

The sound concept of rain varies according to the experience given by the place where you live [intensity / regularity]. I don't think there can be such a thing as a universal rain:
output-1


P.S. If Blanket is able to expand the catalog or work with "add-on packages" in the future, I suggest a couple of clips as a concept:

@CharoSW
Copy link

CharoSW commented Oct 5, 2020

Would it be possible to add Brown noise along side the Pink and White noise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants