Dropping gnome-icons.css

[rafaelmardojai]

Soon GNOME icons will be included in theme as SVG to fix #8. And Adwaita icon theme will be "hardcoded".

So gnome-icons.css main functionality will be included by default.

But I'm considering create system-icons.css, with similar functionality, for the ones not using Adwaita icons and want to use their system icon theme. But facing moz-icon://stock/ issues.

[lionirdeadman]

Why would the code using the SVG not be simply put in gnome-icons.css?

[rafaelmardojai]

gnome-icons.css was out of "core" because it was partially broken, the SVG implementation will not.
So no reason to continue out. Or do you think most people prefer default Firefox icons?

[lionirdeadman]

Ah, I see. I never knew it was partially broken. Then sure, I don't see a problem

[lionirdeadman]

This seems to give a lot of icons a dark color :/

[rafaelmardojai]

:/ Screenshot?

[lionirdeadman]

:/

[rafaelmardojai]

Are you using system-icons.css or default?

[lionirdeadman]

Default although my customChrome.css has

@import "theme/matching-autocomplete-width.css";
@import "theme/hide-single-tab.css";
@import "theme/matching-autocomplete-width.css";
@import "theme/hide-single-tab.css";
@import "theme/matching-autocomplete-width.css";
@import "theme/gnome-icons.css"

(Duplication caused by the script, should probably fix that unless we tell users to update the git from the profile dir instead of using the script all the time)
(Edit : Also had not noticed but the script has other errors if you keep using the script, we should probably just document how to update from the profile directory)

[lionirdeadman]

Adding system-icons.css fixed it.

[rafaelmardojai]

Adding system-icons.css fixed it.

No, it should work without it. But anyways now is fixed, a colon was missing xD

[rafaelmardojai]

We should add an update script.

[lionirdeadman]

An update script can't really work without duplication.

[rafaelmardojai]

Why? It only should run git pull origin master and maybe remove profile cache if needed.

[rafaelmardojai]

It will not work for forks, but will make the work for regular users.

[lionirdeadman]

Because the update script itself can't be updated

Let's say, I have a copy in ~/Downloads which I use to update, this update script can never be updated unless we update (with git pull) both the ~/Downloads copy and the profile directory's copy.

[rafaelmardojai]

What about creating the gnomish-optional-features.css file?

@import "theme/hide-single-tab.css"; 
@import "theme/matching-autocomplete-width.css";

Then check with grep if @import "gnomish-optional-features.css"; exists in customChrome.css before adding it.

Or check if firefox-gnome-theme exists, en delete it before coping.