Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'new tab' system icon is stretched when tab manager is displayed #755

Closed
Phillip-Drake opened this issue Feb 13, 2024 · 1 comment
Closed

'new tab' system icon is stretched when tab manager is displayed #755

Phillip-Drake opened this issue Feb 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Phillip-Drake
Copy link
Contributor

Phillip-Drake commented Feb 13, 2024 •
edited
Loading

Describe the bug

'new tab' system icon is stretched when tab manager appears, likely due to a contorted aspect ratio.

To Reproduce

  1. Go to 'about:config'
  2. Create variable 'gnomeTheme.systemIcons'
  3. Set new variable to 'true'
  4. Create tabs until tab manager appears

Expected behavior

'new tab' system icon displayed as expected :
Screenshot from 2024-02-12 18-59-30

Screenshots

As can be seen, the 'new tab' system icon is now stretched.
Screenshot from 2024-02-12 18-54-33

Setup information

  • OS: Fedora 39
  • Installation method: Curl script
  • Firefox version: 122
  • Theme version: master
  • Optional features enabled: gnomeTheme.systemIcons, gnomeTheme.tabsAsHeaderBar

Additional context

Issue is agnostic of gnomeTheme.tabsAsHeaderBar being enabled, but is not reproducible when gnomeTheme.systemIcons is disabled. I am using Adwaita icon pack
@Phillip-Drake Phillip-Drake added the bug Something isn't working label Feb 13, 2024
@Phillip-Drake Phillip-Drake changed the title System icon displays as stretched when tab manager is displayed System icon is stretched when tab manager is displayed Feb 13, 2024
@Phillip-Drake Phillip-Drake changed the title System icon is stretched when tab manager is displayed 'new tab' system icon is stretched when tab manager is displayed Feb 13, 2024
Phillip-Drake added a commit to Phillip-Drake/firefox-gnome-theme that referenced this issue Feb 20, 2024
@Phillip-Drake
Issue rafaelmardojai#755 Fix
80c868e 
Fixed Issue rafaelmardojai#755 by locking size of new tab icon when system icons are enabled. Please see bug report for more description.
@Phillip-Drake Phillip-Drake mentioned this issue Feb 20, 2024
Merged
@Phillip-Drake
Copy link
Contributor Author

Created pull request for master branch including a fix for this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaelmardojai @Phillip-Drake