Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

When TTL is set, ignore the maxAge. #3

Merged
merged 1 commit into from
Aug 29, 2019
Merged

When TTL is set, ignore the maxAge. #3

merged 1 commit into from
Aug 29, 2019

Conversation

stephankaag
Copy link
Contributor

This makes is possible to have long living cookies with shorter sessions (TTL).

This makes is possible to have long living cookies with shorter sessions (TTL).
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 95.862% when pulling 2cd0200 on stephankaag:ttl-is-more-import-than-max-age into b8d5410 on rafaelrpinto:master.

@rafaelrpinto
Copy link
Owner

Hi @stephankaag,

Thanks for the PR.

I will merge this and once I update the documentation with the new behaviour I will push a new major version.

Cheers,

@rafaelrpinto rafaelrpinto merged commit a5657b8 into rafaelrpinto:master Aug 29, 2019
@stephankaag stephankaag deleted the ttl-is-more-import-than-max-age branch August 29, 2019 18:15
@stephankaag
Copy link
Contributor Author

@rafaelrpinto Thanks! Don't forget to update the dist dir. It is now outdated.

@stephankaag
Copy link
Contributor Author

@rafaelrpinto
Copy link
Owner

@stephankaag

Sure. I will upgrade some dependencies too as yarn audit is giving me some security alerts.

Thanks

@rafaelrpinto
Copy link
Owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants