memory leak calling cgi_unescape_special_chars()

[LeSpocky]

The function cgi_unescape_special_chars() allocates some memory based on the length of the input string and returns the pointer to this new allocated memory as output. The function is used twice in LibCGI and in neither case the memory is freed again although not used further.

First is in cgi_get_cookies() where the pointer taking the return argument is overwritten multiple times before the memory can be freed.

Second is in process_data() where the result is directly fed in another function giving you no chance to free it again.

In environments with small memory this leads to problems processing large form data with lots of key/value pairs.

[rafaelsteil]

Can you make a patch and pull request? I'll be glad to apply to the main repository. Thanks

[LeSpocky]

On Tue, Oct 23, 2012 at 09:53:39AM -0700, Rafael Steil wrote:

Can you make a patch and pull request? I'll be glad to apply to the main repository. Thanks

I will. I filed this to remind myself what needs to be fixed. ;)