CMakeLists.txt: don't force the build of a shared library #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building a shared library doesn't work on all platforms, so instead, let CMake rely on the standard BUILD_SHARED_LIBS variable to decide whether a static or shared library should be built. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
LeSpocky
reviewed
Sep 3, 2017
| EXPORT ${PROJECT_NAME}-targets | ||
| LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}" | ||
| ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}" |
There was a problem hiding this comment.
How is that related to the BUILD_SHARED_LIBS variable change?
There was a problem hiding this comment.
If BUILD_SHARED_LIBS is off, a static library is built, and cmake uses the "ARCHIVE DESTINATION" to know where to install it, while the "LIBRARY DESTINATION" is used when a shared library is built.
|
If I would add an option in CMakeLists.txt to set BUILD_SHARED_LIBS to ON by default, this would still allow to let buildroot or any other build system or user to set it to OFF, right? Then I could take this PR, add this option in another commit and keep the previous behaviour. |
LeSpocky
added a commit
to LeSpocky/libcgi
that referenced
this pull request
Sep 11, 2017
PR rafaelsteil#39 changed the behaviour to support building a shared or static library based on the global CMake variable BUILD_SHARED_LIBS, but the build system had to set it from outside. Now it's an option and the user can easily set it in the CMake GUI, while setting from outside is of course still possible. Additionally this allows us to change the default from building a static library to building a shared library like it was before PR rafaelsteil#39.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a shared library doesn't work on all platforms, so instead,
let CMake rely on the standard BUILD_SHARED_LIBS variable to decide
whether a static or shared library should be built.
Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com