Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak test accuracy and revert ranking algo because new one was Dj2 only #1114

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Oct 25, 2018

This PR reverts users activity ranking implementation to old one, because new one was using features not present in Django 2 (but not raising errors in Django 1.11).

Our (messy) test case has also been tweaked to test that users that posted outside of ranked period don't show on ranking.

Fixes #1110

@rafalp rafalp added bug area: backend This issue involves Python, Django or dependency (eg. database) labels Oct 25, 2018
@rafalp rafalp added this to the 0.19.3 milestone Oct 25, 2018
@rafalp rafalp self-assigned this Oct 25, 2018
@rafalp rafalp merged commit f02cfca into master Oct 26, 2018
@rafalp rafalp deleted the fix-build-active-users-ranking branch October 26, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant