Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global state from ACL #1145

Merged
merged 47 commits into from Dec 18, 2018
Merged

Remove global state from ACL #1145

merged 47 commits into from Dec 18, 2018

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Dec 9, 2018 •
edited

This PR removes global state from ACL.

TODO

  • Create new get_user_acl
  • Create testing util for overriding ACL
  • Simplify patch_user_acl test util to patch all users acl's
  • Remove override_acl from tests (fixes Make override_acl utility less fragile and flaky #580)
  • Make permission checks use request.user_acl
  • Remove User.acl_cache and User.acl_
  • Remove importing directly from misago.acl
  • Cleanup misago.acl cache versions
  • Test that changing ACL invalidates ACL cache
  • Update debug toolbar extension
  • Update docs

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience labels Dec 9, 2018
@rafalp rafalp added this to the 0.20.0 milestone Dec 9, 2018
@rafalp rafalp self-assigned this Dec 9, 2018
@rafalp
Include user staff and superuser status flags in user_acl
8ef7c58
@rafalp
Make tests pass for misago.users
1e2df6e
@rafalp
Improve get_user_status tests
0354f43
@rafalp
Improve patch_user_acl testing utility and get_user_status tests
8e63ac7
@rafalp
Improve test util to work as decorator or context processor
55156a8
@rafalp
Update misago.users tests to use new testing utilities
263dff9
@rafalp
Update readtracker to use user_acl
cc47a3b
@rafalp
Remove cache and global state dependency from readtracker tests
aebcf97
@rafalp
Fix tests for thread view
d2be86e
@rafalp
Move more tests to patch_user_acl
0115195
@rafalp
Make misago.categories tests pass
7a38bd6
@rafalp
Redo patch_user_acl test util
7e79a26
@rafalp
Make threads patch api tests pass
95f9ff5
@rafalp
Enable stacking patch_user_acl helper
37bf66b
@rafalp
Make tests pass for thread and post patch api, redo thread_move test …
4ba48a7 
…util
@rafalp
Remove unnecessary extra model refreshing logic
bd18790
@rafalp
Fix tests for threads editor api
4307c0a
@rafalp
Make override_acl function raise error on use
a818432
@rafalp
Tweak test util and fix regressions in misago.users.tests
bf157d8
@rafalp
Fix misago.search tests
56cc7c6
@rafalp
Fix merging threads
19d77ea
@rafalp
Make tests for thread start/reply/edit reply pass
5b48ed6
@rafalp
Fix threads api tests
e7cd7e1
@rafalp
Fix threads splitting
637ec70
@rafalp
Fix bulk post delete
35a80d0
@rafalp
Fix post merge api
b3dd25a
@rafalp
Fix post deletion
489741b
@rafalp
Fix posts moving
2f0befd
@rafalp
Fix attachments api tests
e353027
@rafalp
Fix attachments
a0bd67c
@rafalp
Replace RequestMock with unittest.mocks.Mock
26cc404
@rafalp
Fix bulk threads delete tests
5750abf
@rafalp
Fix private threads to work with new acl
0d79134
@rafalp
Fix remaining posting middlewares
b489fdb
@rafalp
Remove override_acl from remaining tests
4a75270
@rafalp
Make tests pass
14ddb2f
@rafalp
Cleanup misago.acl a little
35bee7a
@rafalp
Remove User.acl_cache, User.acl_ and direct imports from misago.acl
3a907dd
@rafalp
Fix allow_lift_ban permission
593a0fd
@rafalp
Add assertion for testing if cache is invalidated
e912a78
@rafalp
Add assertions that ACL cache is invalidated
27ed8cd
@rafalp
Fix assertion error message
d52d2da
@rafalp
Small name change
3e45c7c
@rafalp
Clean the test
f5a2d60
@rafalp
Small change of misago.acl.cache api
210d552
@rafalp
Fix build
8eff6f4
@rafalp rafalp merged commit 7f1ee27 into remove-global-state Dec 18, 2018
@rafalp rafalp deleted the remove-global-state-from-acl branch December 18, 2018 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rafalp