New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cursor-based pagination #1197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
added
area: backend
This issue involves Python, Django or dependency (eg. database)
new feature
New feature
labels
Jan 20, 2019
rafalp
changed the title
Add utility for cursor-based pagination
Add cursor-based pagination
Jan 20, 2019
rafalp
added
enhancement
Improvement to existing feature or dev experience
and removed
new feature
New feature
labels
Jan 20, 2019
rafalp
force-pushed
the
add-cursor-paginator
branch
from
January 27, 2019 16:07
1af11d9
to
0c34e5d
Compare
Observation after quick tests: On larger dataset (130k threads) cursor based pagination is 20x faster than offset pagination, returning results in 5ms vs 100ms. |
Note: for now I am skipping the search, because its ordering the results by accuracy. I'll revisit it down the road. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: backend
This issue involves Python, Django or dependency (eg. database)
enhancement
Improvement to existing feature or dev experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
misago.core.cursorpaginator.CursorPaginator
utility for implementing cursor pagination in Misago.Fixes #1066
TODO
MISAGO_THREADS_TAIL
setting (from settings.py and docs)