Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MISAGO_ADDRESS with forum_address #1236

Merged
merged 9 commits into from
May 24, 2019
Merged

Replace MISAGO_ADDRESS with forum_address #1236

merged 9 commits into from
May 24, 2019

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented May 23, 2019 •
edited
Loading

This PR replaces MISAGO_ADDRESS with forum_address, making it easier for site owners to fix their site's configuration... or break it ;)

TODO

  • Replace all MISAGO_ADDRESS uses with forum_address
  • Replace all SITE_ADDRESS, SITE_HOST and REQUEST_PATH uses
  • Update tests
  • Update docs

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience labels May 23, 2019
@rafalp rafalp added this to the 0.20.0 milestone May 23, 2019
@rafalp rafalp self-assigned this May 23, 2019
@rafalp rafalp mentioned this pull request May 24, 2019
Closed
@rafalp rafalp merged commit d614318 into master May 24, 2019
@rafalp rafalp deleted the add-forum-address branch May 24, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rafalp