Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link check lenient #1564

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Apr 18, 2023

Changes isUrl logic to just check if selected text starts with http/ftp. If it does, selection is used to pre-fill url input instead of text input.

Also removes URL validation from "url" textinput, so its up to users to provide valid links.

Fixes #1562

@rafalp rafalp added bug area: frontend This issue involves JavaScript, React.js and Node labels Apr 18, 2023
@rafalp rafalp added this to the 0.34 milestone Apr 18, 2023
@rafalp rafalp self-assigned this Apr 18, 2023
@coveralls
Copy link

Coverage Status

Coverage: 97.565% (-0.04%) from 97.603% when pulling 6c60b8c on fix-1562-remove-editor-link-validation into 8278c78 on master.

@rafalp rafalp merged commit 857b7f0 into master Apr 18, 2023
@rafalp rafalp deleted the fix-1562-remove-editor-link-validation branch April 18, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend This issue involves JavaScript, React.js and Node bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link validation in editor's "insert" action is invalid.
2 participants