forked from brainmap/nifti
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unfortunately, the file that reproduces this error is classified for now. So no tests for now :(
- Loading branch information
Showing
1 changed file
with
23 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b670ec4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that file is failing, but I'm glad you found a fix. Any way we can duplicate the error in a good file that could be added to the tests? Let me know if you want me to pull it into master!
b670ec4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Erik,
I've already opened a bug on the Ruby Redmine to see if this issue gets fixed: https://bugs.ruby-lang.org/issues/10101
But, to be honest I don't have big expectations that this might get fixed there, since the ZLib extension doesn't have a maintainer right now.
I'll make a final test later today or tomorrow morning with this patch that I've suggested here and I'll get back to you if it's good for merge.
Thanks!
b670ec4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it against the file, but besides this fix makes possible to read the header. The image data is completely wrong :(
So It's better to not merge this fix and just raise the current exception instead of giving wrong information :(
I've just cloned the ruby source to see if I understand the issue there...