feat(core): adds explicit interfaces for create functions options

rafamel · Oct 13, 2019 · f1e229d · f1e229d
1 parent b1a7606
commit f1e229d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/packages/core/src/create/application/index.ts b/packages/core/src/create/application/index.ts
@@ -2,7 +2,8 @@ import {
   CollectionTreeImplementation,
   CollectionTreeApplication,
   CollectionTree,
-  TreeTypes
+  TreeTypes,
+  CreateApplicationOptions
 } from '~/types';
 import clone from 'lodash.clonedeep';
 import { traverse, isElementType } from '~/utils';
@@ -12,14 +13,8 @@ import { mergeServiceTypes } from './merge';
 
 export default function application(
   collection: CollectionTree | CollectionTreeImplementation,
-  options?: {
-    prefixScope?: boolean;
-    prefixInlineError?: boolean;
-    transform?: (str: string, explicit: boolean) => string;
-  }
+  options?: CreateApplicationOptions
 ): CollectionTreeApplication {
-  collection = clone(collection);
-
   const opts = Object.assign(
     {
       prefixScope: true,
@@ -29,6 +24,9 @@ export default function application(
     options
   );
 
+  // clone collection
+  collection = clone(collection);
+
   const types = {
     source: collection.types,
     application: Object.entries(collection.types).reduce(

diff --git a/packages/core/src/create/intercepts.ts b/packages/core/src/create/intercepts.ts
@@ -2,7 +2,8 @@ import {
   InputInterceptHook,
   InterceptImplementation,
   InputIntercept,
-  CollectionTreeImplementation
+  CollectionTreeImplementation,
+  CreateInterceptsOptions
 } from '~/types';
 import { from, Observable } from 'rxjs';
 import { switchMap, mergeMap } from 'rxjs/operators';
@@ -17,7 +18,7 @@ import {
 export function intercepts<T extends CollectionTreeImplementation>(
   collection: T,
   intercepts: InterceptImplementation[],
-  options?: { prepend?: boolean }
+  options?: CreateInterceptsOptions
 ): T {
   collection = clone(collection);
   const opts = Object.assign({ prepend: true }, options);

diff --git a/packages/core/src/types/create.ts b/packages/core/src/types/create.ts
@@ -12,6 +12,17 @@ import {
 import { Observable } from './observable';
 import { Schema } from './schema';
 
+// Options
+export interface CreateApplicationOptions {
+  prefixScope?: boolean;
+  prefixInlineError?: boolean;
+  transform?: (str: string, explicit: boolean) => string;
+}
+
+export interface CreateInterceptsOptions {
+  prepend?: boolean;
+}
+
 // Collection
 export type InputCollection =
   | Partial<CollectionTree>