fix: coerce unknown thrown objects into errors

rafamel · Sep 17, 2021 · 38b9e22 · 38b9e22
1 parent bbbf2fe
commit 38b9e22
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/cli/bin/execute.ts b/src/cli/bin/execute.ts
@@ -1,4 +1,5 @@
 import { NullaryFn } from 'type-core';
+import { ensure } from 'errorish';
 import { stringifyError } from '../../helpers/stringify';
 import { create, log } from '../../tasks';
 import { Task } from '../../definitions';
@@ -28,7 +29,7 @@ export async function execute(task: NullaryFn<Task>): Promise<void> {
 
     await promise;
   } catch (err) {
-    await run(null, log('error', stringifyError(err)));
+    await run(null, log('error', stringifyError(ensure(err))));
     return process.exit(1);
   }
 }
diff --git a/src/tasks/exception/catches.ts b/src/tasks/exception/catches.ts
@@ -1,5 +1,6 @@
 import { Empty } from 'type-core';
 import { shallow } from 'merge-strategies';
+import { ensure } from 'errorish';
 import { into } from 'pipettes';
 import { Task, Context, LogLevel } from '../../definitions';
 import { stringifyError } from '../../helpers/stringify';
@@ -36,7 +37,7 @@ export function catches(
       await into(
         series(
           log('trace', err),
-          log(opts.level, stringifyError(err)),
+          log(opts.level, stringifyError(ensure(err))),
           alternate
         ),
         (task) => run(ctx, task)

diff --git a/src/tasks/exception/finalize.ts b/src/tasks/exception/finalize.ts
@@ -1,4 +1,5 @@
 import { Empty, Dictionary } from 'type-core';
+import { ensure } from 'errorish';
 import { Task } from '../../definitions';
 import { run } from '../../utils/run';
 import { flatten } from '../../helpers/flatten';
@@ -30,7 +31,7 @@ export function finalize(
               try {
                 await run(ctx, item);
               } catch (err) {
-                errors.push(err);
+                errors.push(ensure(err));
               }
             })
           : null;

diff --git a/src/tasks/stdio/prompt.ts b/src/tasks/stdio/prompt.ts
@@ -1,6 +1,7 @@
 import { Empty, TypeGuard, UnaryFn, VariadicFn } from 'type-core';
 import { shallow } from 'merge-strategies';
 import { createInterface } from 'readline';
+import { ensure } from 'errorish';
 import { Context, Task } from '../../definitions';
 import { getBadge } from '../../helpers/badges';
 import { addPrefix } from '../../helpers/prefix';
@@ -107,7 +108,7 @@ export function prompt(options: PromptOptions | Empty, task: Task): Task.Async {
       try {
         valid = opts.validate(response);
       } catch (err) {
-        error = [err];
+        error = [ensure(err)];
       }
 
       if (valid && !error) {