feat(utils/exec): kills dangling child processes on main process exit

package.json

@@ -73,6 +73,8 @@
     "@types/js-yaml": "^3.12.1",
     "@types/lodash.mergewith": "^4.6.6",
     "@types/object-hash": "^1.2.0",
+    "@types/signal-exit": "^3.0.0",
+    "@types/uuid": "^3.4.4",
     "@typescript-eslint/eslint-plugin": "^1.6.0",
     "@typescript-eslint/parser": "^1.6.0",
     "@zerollup/ts-transform-paths": "^1.7.1",
@@ -124,9 +126,11 @@
     "manage-path": "^2.0.0",
     "object-hash": "^1.3.1",
     "promist": "^0.5.3",
+    "signal-exit": "^3.0.2",
     "slimconf": "^0.9.0",
     "spawn-command": "0.0.2-1",
-    "string-argv": "^0.3.0"
+    "string-argv": "^0.3.0",
+    "uuid": "^3.3.2"
   },
   "husky": {
     "hooks": {

src/utils/exec/index.ts

@@ -1,9 +1,17 @@
 import sc from 'spawn-command';
-import { SpawnOptions } from 'child_process';
+import { SpawnOptions, ChildProcess } from 'child_process';
 import { DEFAULT_STDIO } from '~/constants';
 import logger from '~/utils/logger';
 import { rejects } from 'errorish';
 import getEnv from './get-env';
+import onExit from 'signal-exit';
+import uuid from 'uuid/v4';
+import { IOfType } from '~/types';
+
+export const processes: IOfType<ChildProcess> = {};
+
+// Kill all dangling child processes on main process exit
+onExit(() => Object.values(processes).forEach((p) => p.kill()));
 
 export default async function exec(
   command: string,
@@ -15,12 +23,18 @@ export default async function exec(
   if (!opts.env) opts.env = await getEnv();
 
   logger.debug('Executing: ' + command);
+  const id = uuid();
   const ps = sc(command, opts);
+  processes[id] = ps;
 
   return new Promise((resolve: (arg: void) => void, reject) => {
     ps.on('close', (code: number) => {
+      delete processes[id];
       return code ? reject(Error(`Failed: ${command}`)) : resolve();
     });
-    ps.on('error', (err: any) => reject(err));
+    ps.on('error', (err: any) => {
+      delete processes[id];
+      return reject(err);
+    });
   }).catch(rejects);
 }