Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented recognition of wheel straight #8 and #11 #35

Merged
merged 1 commit into from
Jan 7, 2014

Conversation

Naktibalda
Copy link
Contributor

No description provided.

@rafanoronha
Copy link
Owner

Thanks and welcome aboard!

rafanoronha added a commit that referenced this pull request Jan 7, 2014
Implemented recognition of wheel straight #8 and #11
@rafanoronha rafanoronha merged commit 98f09a6 into rafanoronha:master Jan 7, 2014
@Naktibalda
Copy link
Contributor Author

Hi,

My objectives in this project are:

  1. Contribute
  2. Learn Scala
  3. Learn Git

End result is not really important to me, as I have no use for poker
server, but poker is an interesting subject to work on.

Today I went through majority of the code, but it will take time to sink in.
I will work #15 "follow tie breaking rules" next,
but I don't know what I could do after that.
Maybe I will try to test showdown.

Kind Regards,

Gintautas

On Tue, Jan 7, 2014 at 6:38 PM, rafanoronha notifications@github.comwrote:

Merged #35 #35.


Reply to this email directly or view it on GitHubhttps://github.com//pull/35
.

@rafanoronha
Copy link
Owner

@Naktibalda

Thanks for sharing your thoughts.
Learning of Scala also motivated the start of this project.

Tie breaking rules should have a bunch of ground to be covered.
Showdown really needs some test coverage.
Have a look at TableSpec [1] regarding the setup of a showdown scenario.

In the next weeks I'm going to look for more issues around stuff needing fixes and improvements.
Please get in touch if you want talk about some aspect of the code base.

Best,

Rafael

[1] https://github.com/rafanoronha/scala-poker/blob/master/src/test/scala/spoker/TableSpec.scala#L34

@rafanoronha
Copy link
Owner

@Naktibalda you might be interested in #39 as a way of going deeper in spoker.betting and spoker.betting.stack code base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants