Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add copy and othe single arg methods to force dispatch on parent type #13

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Oct 14, 2019

also tweak sparse benchmarks, and benchmark copy

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #13 into master will decrease coverage by 0.21%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   65.63%   65.42%   -0.22%     
==========================================
  Files          10       10              
  Lines         291      295       +4     
==========================================
+ Hits          191      193       +2     
- Misses        100      102       +2
Impacted Files Coverage Δ
src/array.jl 45% <100%> (+1.41%) ⬆️
src/methods.jl 79.54% <33.33%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9eeb37...6b41d10. Read the comment docs.

@rafaqz rafaqz changed the title add copy method to force dispatch on parent type add copy and othe single arg methods to force dispatch on parent type Oct 14, 2019
@rafaqz rafaqz merged commit e55b85f into master Oct 14, 2019
@rafaqz rafaqz deleted the copy branch November 26, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants