Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broadcast_dims with groupby #684

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix broadcast_dims with groupby #684

merged 2 commits into from
Apr 4, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Apr 4, 2024

No description provided.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 83.77%. Comparing base (c09557d) to head (d0aec4c).

Files Patch % Lines
src/Dimensions/format.jl 0.00% 4 Missing ⚠️
src/groupby.jl 66.66% 3 Missing ⚠️
src/dimindices.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   83.68%   83.77%   +0.09%     
==========================================
  Files          46       46              
  Lines        4205     4229      +24     
==========================================
+ Hits         3519     3543      +24     
  Misses        686      686              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit b69b48f into main Apr 4, 2024
7 of 10 checks passed
@rafaqz rafaqz deleted the broadcastdims_groupby branch April 4, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant