Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deploy docs #686

Merged
merged 4 commits into from
Apr 4, 2024
Merged

fix deploy docs #686

merged 4 commits into from
Apr 4, 2024

Conversation

lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented Apr 4, 2024

@rafaqz this should fix the docs deploy, and possibly the stable redirect issue ~ 90% confidence 😓 .

@asinghvi17
Copy link
Collaborator

asinghvi17 commented Apr 4, 2024

@lazarusA want to push a tag on this commit to test? I am on the move so can't atm

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (c09557d) to head (4046ffb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   83.68%   83.28%   -0.41%     
==========================================
  Files          46       46              
  Lines        4205     4224      +19     
==========================================
- Hits         3519     3518       -1     
- Misses        686      706      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

mmm... the deploy was cancelled due to the one happening in master. I will retry later.

@rafaqz
Copy link
Owner

rafaqz commented Apr 4, 2024

I can also just merge? About to bump a version anyway

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 4, 2024

yes, please. Merge.

@rafaqz rafaqz merged commit a22fc49 into main Apr 4, 2024
8 of 10 checks passed
@rafaqz rafaqz deleted the la/fix_deploy branch April 4, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants