(Slightly) Breaking: make name
more systematic
#687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me for a while.
name
was originally defined for informative names, but it became the actual keys for Table columns and DimStack layers.name
on dimensions is still this thing that can be modified in thedims
macro to look bettter, anddim2key
does the lower level thing for Symbol keys/table columns etc. Butname
is exported and should be much more useful than it is.This PR removes all of that coomplexity and makes
name
the main function for getting the dimension name Symbol from Dimension, types etc..name(Ti) == :Ti
.dim2key
is deprecated to just callname
.key2dim
is also switched toname2dim
to simplify things, andname
is defined onDimStack
to just return a Tuple of Symbol for each layer.Plot output mostly wont even change because
label
now holds the oldname
of the dimension andTi
will still be on plot labels as "Time".