Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Slightly) Breaking: make name more systematic #687

Merged
merged 8 commits into from
Apr 15, 2024
Merged

(Slightly) Breaking: make name more systematic #687

merged 8 commits into from
Apr 15, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Apr 4, 2024

This has been bugging me for a while.

name was originally defined for informative names, but it became the actual keys for Table columns and DimStack layers.

name on dimensions is still this thing that can be modified in the dims macro to look bettter, and dim2key does the lower level thing for Symbol keys/table columns etc. But name is exported and should be much more useful than it is.

This PR removes all of that coomplexity and makes name the main function for getting the dimension name Symbol from Dimension, types etc.. name(Ti) == :Ti.

dim2key is deprecated to just call name. key2dim is also switched to name2dim to simplify things, and name is defined on DimStack to just return a Tuple of Symbol for each layer.

Plot output mostly wont even change because label now holds the old name of the dimension and Ti will still be on plot labels as "Time".

@rafaqz rafaqz changed the title (Slightly) Breaking: make name more systematic (Slightly) Breaking: make name more systematic Apr 4, 2024
@rafaqz rafaqz merged commit ae05e7b into main Apr 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant