Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm icon links #688

Merged
merged 7 commits into from
Apr 8, 2024
Merged

rm icon links #688

merged 7 commits into from
Apr 8, 2024

Conversation

lazarusA
Copy link
Collaborator

@lazarusA lazarusA commented Apr 5, 2024

as less as possible content in landing page. Minimalist hero page.

Same component as in Tyler.jl, which is working.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (511734d) to head (1221416).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   83.79%   83.81%   +0.01%     
==========================================
  Files          46       46              
  Lines        4227     4226       -1     
==========================================
  Hits         3542     3542              
+ Misses        685      684       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asinghvi17
Copy link
Collaborator

asinghvi17 commented Apr 5, 2024

It may not be the icon links - GeometryOps and SwarmMakie work fine without them, and so did DocumenterVitepress. My bet is that it's some other change.

That being said it can't hurt to check.

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 5, 2024

Yes, indeed is none of them. Now, all missing things are fixed, including the ico file.
Also, I tested the following cached files:

Screenshot 2024-04-05 at 21 04 57

they are not getting updated after each new released tag. They should, we need to find a way to clear these files from the cache and generated new ones, the correct ones. It should be an option for vite in the config file.... at the moment I don't know how. I will need to look into it.

@rafaqz
Copy link
Owner

rafaqz commented Apr 8, 2024

Should we merge this?

@lazarusA
Copy link
Collaborator Author

lazarusA commented Apr 8, 2024

is just small fixes. So, yes merging is ok.

@rafaqz rafaqz merged commit b179f2c into main Apr 8, 2024
16 of 18 checks passed
@rafaqz rafaqz deleted the la/rm_icon_links branch April 8, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants