Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Makie compat + patch version #710

Closed
wants to merge 1 commit into from
Closed

Conversation

asinghvi17
Copy link
Collaborator

No description provided.

@asinghvi17 asinghvi17 mentioned this pull request May 10, 2024
@asinghvi17
Copy link
Collaborator Author

asinghvi17 commented May 10, 2024

  Invalid attribute colormap for plot type MakieCore.Plot{Makie.series}.

is the current error. I'm not sure where that colormap attribute is coming from, though, since it's not anywhere in the test file...

@rafaqz
Copy link
Owner

rafaqz commented May 10, 2024

Maybe theres a default value somewhere...

@lazarusA
Copy link
Collaborator

lazarusA commented May 10, 2024

it looks like series, not longer has a colormap attribute, it should be now just color. Which we were using to extended the amount of colours if we had more than 7 lines.

(it looks like now we should remove it, and let Makie.series do the work)

https://github.com/MakieOrg/Makie.jl/blob/746b03f46282f2385d438b01b486a74ea10f023d/src/basic_recipes/series.jl#L69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants