Add definitions for expand_dimensions to the Makie extension #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrr, gather 'round, ye scurvy dogs, and listen well! The infamous AbstractMatrix band o' pirates, scourge o' the high seas, met their end not by the hand o' the navy, but by those meddlin' kids! Aye, it be true! Just as they were about to loot a treasure-laden galleon, them pesky young'uns swooped in with their clever tricks and caught the lot o' them red-handed. Now, the once-feared AbstractMatrix pirates be languishin' in the brig, their days o' plunderin' and pillagin' naught but a distant memory. Yarrr!
rafaqz
reviewed
Jun 24, 2024
| @@ -503,7 +510,7 @@ function _keywords2dimpairs(x, y) | |||
| end | |||
| end | |||
|
|
|||
| _floatornan(A::AbstractArray{<:Union{Missing,<:Real}}) = _floatornan32.(A) | |||
| _floatornan(A::AbstractArray{<:Union{Missing,<:Real}}) = _floatornan64.(A) | |||
|
Looks like a Plots.jl version conflict causing some form of downgrade in the nightly CI |
|
Ah right. I've just been ignoring nightly 😅 |
|
Nice lol. If all the CI passes then this looks good to merge to me - I can confirm that my GeoMakie issue is resolved with this. |
rafaqz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #720, fix the issue I was having with plotting Rasters in GeoMakie's meshimage as well.