Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference #4

Open
kongdd opened this issue Jul 6, 2022 · 3 comments
Open

reference #4

kongdd opened this issue Jul 6, 2022 · 3 comments

Comments

@kongdd
Copy link

kongdd commented Jul 6, 2022

Dear @rafaqz

I love many Julia packages that you write.
Could you give some reference of this julia package? I am also very interested about this field. I am eager to use this package.

Cheers,
Dongdong

@rafaqz
Copy link
Owner

rafaqz commented Jul 6, 2022

Hi @kongd!

The package is pretty much a rewrite of a subset of the fortran packages MEASPA and MAESTRA in julia, just more modular than the original, and easy to add new components and change things.

If you want to have it registered, there is probably a little more work left testing everything against the original fortran.

Most of it has been done:
https://github.com/rafaqz/Photosynthesis.jl/tree/master/test

But clearly a bunch of the code is not covered:
https://codecov.io/gh/rafaqz/Photosynthesis.jl/tree/master/src

It should also be swapped over to using my ModelParameters.jl instead of FieldMetadata.jl packages, as ModelParameters.jl is much less confusing.

I don't really have time for this anymore, because it was my masters project and I don't work directly on plant physiological models anymore, and I have too many other packages now.

But if you want to work on it and get it registered as a co-maintainer I can help with your PRs.

cheers

@rafaqz
Copy link
Owner

rafaqz commented Jul 6, 2022

Also you need photsynthesis tools, you should also look a yujie wangs packages, https://github.com/Yujie-W, hes more in the field than I am.

@kongdd
Copy link
Author

kongdd commented Jul 10, 2022

Thank you @rafaqz . Further progress, I will let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants