Adding support for TLS DOCKER_HOST #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workarounds courtesy of fsouza/go-dockerclient#173. They can likely be removed after better support for TLS docker connections is added to go-dockerclient.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| fmt.Println(endpoint) |
There was a problem hiding this comment.
Think you may have forgotten to remove this line
|
|
||
| // Only reliable way to determine if we should be using HTTPS appears to be via port | ||
| if port == "2376" { | ||
| u.Scheme = "https" |
There was a problem hiding this comment.
This should be able to be overwritten by an env var that explicitly sets the scheme (i.e. I can use port 12345 and still force https)
|
Uh oh, merge conflicts 😿 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds courtesy of
fsouza/go-dockerclient#173. They can likely be
removed after better support for TLS docker connections is added to
go-dockerclient.