Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider to move as a general utility function. #48

Closed
todo bot opened this issue Aug 25, 2021 · 1 comment · Fixed by #80
Closed

consider to move as a general utility function. #48

todo bot opened this issue Aug 25, 2021 · 1 comment · Fixed by #80
Assignees
@Raffaello
Labels
refactor refactoring code, same functionality, but better code todo 🗒️
Projects
sound devices, libraries, notes...
Milestone
AdLib / SoundBlas...

Comments

@todo
Copy link

todo bot commented Aug 25, 2021

https://github.com/Raffaello/sdl2-sonic-drivers/blob/00d07a2fb0dadb6a7176d36b50315df95b8e2311/sdl2-sonic-drivers/src/hardware/opl/scummvm/dosbox/dosbox.cpp#L17-L22

This issue was generated by todo based on a TODO comment in 00d07a2 when #26 was merged. cc @Raffaello.
@todo todo bot added the todo 🗒️ label Aug 25, 2021
@todo todo bot assigned Raffaello Aug 25, 2021
@Raffaello Raffaello added the refactor refactoring code, same functionality, but better code label Aug 26, 2021
@Raffaello Raffaello added this to To do in sound devices, libraries, notes... via automation Aug 26, 2021
@Raffaello Raffaello added this to the AdLib milestone Aug 26, 2021
@Raffaello Raffaello mentioned this issue Aug 26, 2021
Closed
@Raffaello Raffaello linked a pull request Aug 29, 2021 that will close this issue
Adlib refactor. Fixes #68 #80
Merged
@Raffaello
Copy link
Owner

fixed by #80

sound devices, libraries, notes... automation moved this from To do to Done Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffaello Raffaello

Labels
refactor refactoring code, same functionality, but better code todo 🗒️
Projects
sound devices, libraries, notes...
Done
Milestone
AdLib / SoundBlaster Pro
Development

Successfully merging a pull request may close this issue.

Adlib refactor. Fixes #68 Raffaello/sdl2-hyper-sonic-drivers
1 participant
@Raffaello