Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with custom-model-data in ingredient parameters #4

Open
raffel080108 opened this issue Dec 12, 2023 · 4 comments
Open

Issue with custom-model-data in ingredient parameters #4

raffel080108 opened this issue Dec 12, 2023 · 4 comments

Comments

@raffel080108
Copy link
Owner

          Hello! Just wanted to thank you for the implementation and I wanted to clarify something too: Theres some issue while trying to add the custom-model-data nbt parameter to ingredientes, but it seems to work flawlessly with the result item. Not sure if i'm doing something wrong, tho. Take a look! 

image

Originally posted by @omgitsKit in #3 (comment)

@raffel080108 raffel080108 self-assigned this Dec 12, 2023
@raffel080108
Copy link
Owner Author

@omgitsKit could you please describe what exactly the issue is, I cannot see an issue in this screenshot directly

@omgitsKit
Copy link

the issue is: the custom model data parameter works with the result, but apparently isn't working with ingredientes. Having a "Paper" with "custom-model-data: 50" as ingredient isn't working, but having a "Paper" with "custom-model-data: 50" as result is.

@raffel080108
Copy link
Owner Author

raffel080108 commented Dec 12, 2023

Hello, could you please tell me what exactly isn't working with the ingredients?
To make sure I didn't overlook something in my past testing, I have just downloaded the latest jar from spigot and fired up a test server and it seems to work perfectly fine for me.
The recipe will not work if the item has missing or incorrect custom-model-data and it will work if the item has the correct custom-model-data.

Could you please also tell me which plugin version (e.g. 1.3.4) and which server-software and version you are using (e.g. Paper 1.20.2)

@omgitsKit
Copy link

omgitsKit commented Dec 13, 2023

Hey there! I've been trying some stuff out and it seems like the problem is this: I'm using two nbt parameters, custom-model-data and name. I've got a custom item (material: paper) called "&fAcônito" with a custom-model-data of 4800072, just like in the picture below. But when I set the recipe ingredient to be paper with a custom-model-data of 4800072 and the custom name "&fAcônito", the plugin thinks it's an invalid recipe, even though the ingredient meets all the criteria (material, name, and custom-model-data).

In my testings the plugin doens't have any issue when the recipe needs a paper with a custom-model-data but doesn't need to check for a "name" parameter.

I'm using AltarCraft 1.3.4 for purpur 1.19.4.
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants