removed Metabase::Fact::TestFact from tests

Using private Test::Metabase::StringFact from t/lib instead

t/index/flatfile.t

@@ -30,7 +30,7 @@ ok( my $index = $TEST->test_index, 'created an index' );
 isa_ok( $index, 'Metabase::Index::FlatFile' );
 
 ok( my $fact = $TEST->test_fact, "created a fact" );
-isa_ok( $fact, 'Metabase::Fact::TestFact' );
+isa_ok( $fact, 'Test::Metabase::StringFact' );
 
 ok( my $guid = $archive->store( $fact ), "stored a fact" );
 

t/lib/Test/Metabase/Report.pm

@@ -0,0 +1,15 @@
+package Test::Metabase::Report;
+use 5.006;
+use strict;
+use warnings;
+use base 'Metabase::Report';
+
+__PACKAGE__->load_fact_classes;
+
+sub report_spec {
+  return {
+    Test::Metabase::Fact => "1+",  # zero or more
+  }
+}
+
+1;

t/lib/Test/Metabase/StringFact.pm

@@ -0,0 +1,21 @@
+package Test::Metabase::StringFact;
+use 5.006;
+use strict;
+use warnings;
+use base 'Metabase::Fact::String';
+
+sub content_metadata {
+  my $self = shift;
+  return {
+    'size' => [ Num => length $self->content ],
+  };
+}
+
+sub validate_content {
+  my $self = shift;
+  $self->SUPER::validate_content;
+  die __PACKAGE__ . " content length must be greater than zero\n"
+  if length $self->content < 0;
+}
+
+1;

t/lib/Test/Metabase/Util.pm

@@ -19,7 +19,7 @@ has test_gateway => (
   default => sub {
     require Metabase::Analyzer::Test;
     my $gateway = Metabase::Gateway->new({
-      fact_classes => [ 'Metabase::Fact::TestFact' ],
+      fact_classes => [ 'Test::Metabase::StringFact' ],
     });
   }
 );
@@ -29,8 +29,21 @@ has test_fact => (
   isa  => 'Metabase::Fact',
   lazy => 1,
   default => sub {
-    require Metabase::Fact::TestFact;
-    Metabase::Fact::TestFact->new( 
+    require Test::Metabase::StringFact;
+    Test::Metabase::StringFact->new( 
+      resource => 'JOHNDOE/Foo-Bar-1.23.tar.gz', 
+      content  => "I smell something fishy.",
+    );
+  },
+);
+
+has test_report => (
+  is   => 'ro',
+  isa  => 'Metabase::Fact',
+  lazy => 1,
+  default => sub {
+    require Test::Metabase::StringFact;
+    Test::Metabase::StringFact->new( 
       resource => 'JOHNDOE/Foo-Bar-1.23.tar.gz', 
       content  => "I smell something fishy.",
     );

t/librarian/simple.t

@@ -26,7 +26,7 @@ require_ok( 'Metabase::Librarian' );
 ok( my $librarian = $TEST->test_librarian, 'created librarian' );
 
 ok( my $fact = $TEST->test_fact, "created a fact" );
-isa_ok( $fact, 'Metabase::Fact::TestFact' );
+isa_ok( $fact, 'Test::Metabase::StringFact' );
 
 ok(
   my $guid = $librarian->store($fact, { user_id => 'Larry' }),

t/storage/filesystem.t

@@ -13,7 +13,7 @@ use File::Temp ();
 use File::Path ();
 
 use lib 't/lib';
-use Metabase::Fact::TestFact;
+use Test::Metabase::StringFact;
 
 #--------------------------------------------------------------------------#
 
@@ -42,12 +42,12 @@ lives_ok {
     $archive = Metabase::Archive::Filesystem->new(root_dir => "$temp_root");
 } "created store at '$temp_root'";
 
-my $fact = Metabase::Fact::TestFact->new( 
+my $fact = Test::Metabase::StringFact->new( 
     resource => $dist_id,
     content  => "I smell something fishy.",
 );
 
-isa_ok( $fact, 'Metabase::Fact::TestFact' );
+isa_ok( $fact, 'Test::Metabase::StringFact' );
 
 ok( my $guid = $archive->store( $fact ), "stored a fact" );