Skip to content

Commit

Permalink
Add MRO_GET_PRIVATE_DATA() to use the cached mro private data where p…
Browse files Browse the repository at this point in the history
…ossible.
  • Loading branch information
nwc10 committed Dec 27, 2008
1 parent fa60396 commit 123892d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions hv.h
Expand Up @@ -57,6 +57,11 @@ struct mro_meta {
HV *isa; /* Everything this class @ISA */
};

#define MRO_GET_PRIVATE_DATA(smeta, which) \
(((smeta)->mro_which && (which) == (smeta)->mro_which) \
? MUTABLE_SV((smeta)->mro_linear_c3) \
: Perl_mro_get_private_data(aTHX_ (smeta), (which)))

/* Subject to change.
Don't access this directly.
*/
Expand Down
4 changes: 2 additions & 2 deletions mro.c
Expand Up @@ -231,7 +231,7 @@ S_mro_get_linear_isa_dfs(pTHX_ HV *stash, U32 level)
meta = HvMROMETA(stash);

/* return cache if valid */
if((retval = MUTABLE_AV(Perl_mro_get_private_data(aTHX_ meta, dfs_alg)))) {
if((retval = MUTABLE_AV(MRO_GET_PRIVATE_DATA(meta, dfs_alg)))) {
return retval;
}

Expand Down Expand Up @@ -382,7 +382,7 @@ S_mro_get_linear_isa_c3(pTHX_ HV* stash, U32 level)
meta = HvMROMETA(stash);

/* return cache if valid */
if((retval = MUTABLE_AV(Perl_mro_get_private_data(aTHX_ meta, c3_alg)))) {
if((retval = MUTABLE_AV(MRO_GET_PRIVATE_DATA(meta, c3_alg)))) {
return retval;
}

Expand Down

0 comments on commit 123892d

Please sign in to comment.