Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds helm chart and demo #178

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Adds helm chart and demo #178

merged 10 commits into from
Jul 1, 2024

Conversation

dagan
Copy link
Member

@dagan dagan commented Jun 30, 2024

No description provided.

@dagan dagan requested a review from JamesB41 June 30, 2024 21:04
@dagan dagan marked this pull request as draft June 30, 2024 21:17
{{- toYaml . | nindent 8 }}
{{- end }}
serviceAccountName: {{ include "konfirm.serviceAccountName" . }}
automountServiceAccountToken: true

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods

<!--SONAR_ISSUE_KEY:AZBrCSF_FJAonniBTiHl-->Set automountServiceAccountToken to false for this specification of kind Deployment. <p>See more on <a href="https://sonarcloud.io/project/issues?id=raft-tech_konfirm&issues=AZBrCSF_FJAonniBTiHl&open=AZBrCSF_FJAonniBTiHl&pullRequest=178">SonarCloud</a></p>
@dagan dagan marked this pull request as ready for review June 30, 2024 21:30
@dagan dagan marked this pull request as draft June 30, 2024 21:39
@dagan dagan marked this pull request as ready for review June 30, 2024 21:39
Copy link

sonarcloud bot commented Jul 1, 2024

Copy link
Contributor

@JamesB41 JamesB41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dagan dagan merged commit 3ad9809 into develop Jul 1, 2024
6 checks passed
@dagan dagan deleted the feature/demo branch July 2, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants