Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple choices rework #782

Merged
merged 16 commits into from
May 31, 2021
Merged

Multiple choices rework #782

merged 16 commits into from
May 31, 2021

Conversation

sebazai
Copy link
Contributor

@sebazai sebazai commented May 11, 2021

Currently Quizzes ver. 0.9.10 only works on Ohjelmointi-21.
Latest version crashes because Ohjelmointi-21 has many quiz items in one quiz.

For Economics MOOC we want to show feedback for each answer option, this is something that we don't want in ohjelmointi-21, even though they have unlimited tries.

Fixes #781 :

  • Show quiz title regardless direction (Hopefully fine for Economics, that uses column a lot)
  • Shows the correct failure/success message if many quiz items (?)
  • Some minor refactoring, which could break things.

To do (Comments please):

  • We need some backend to toggle the option "showFeedbackForEachAnswerOption" ?
    • Once we have this, work on the widget to take this into account
  • Test functionality
  • Make sure this works on Economics, Elements and Ohjelmointi-21 (is there any way to do this without publishing version?)

image

@d471061c d471061c marked this pull request as ready for review May 11, 2021 09:49
@d471061c d471061c marked this pull request as draft May 11, 2021 09:50
@sebazai
Copy link
Contributor Author

sebazai commented May 11, 2021

image

What is the purpose of this checkbox?

If I look at Elements, this checkbox doesn't seem to be toggled and they receive only one feedback when answering a Quiz item and not a feedback for each answer option

@sebazai sebazai requested a review from nygrenh May 11, 2021 11:42
@nygrenh
Copy link
Member

nygrenh commented May 12, 2021

enum QuizItemFeedbackDisplayPolicy {
  DisplayFeedbackOnQuizItem,
  DisplayFeedbackOnAllOptions,
}

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #782 (92152e1) into master (9277cb2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   92.08%   92.09%           
=======================================
  Files          63       63           
  Lines        2010     2011    +1     
  Branches      266      267    +1     
=======================================
+ Hits         1851     1852    +1     
  Misses        153      153           
  Partials        6        6           
Impacted Files Coverage Δ
packages/backendv2/src/models/quiz_item.ts 100.00% <ø> (ø)
packages/backendv2/tests/data.ts 100.00% <ø> (ø)
packages/backendv2/knexfile.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9277cb2...92152e1. Read the comment docs.

@sebazai sebazai marked this pull request as ready for review May 24, 2021 10:39
@sebazai sebazai requested a review from nygrenh May 24, 2021 17:12
@nygrenh nygrenh merged commit 987c680 into master May 31, 2021
@nygrenh nygrenh deleted the multiple-choices branch May 31, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug in multiple choices
4 participants