Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: InvalidArgumentError: conv2d_1_input_1:0 is both fed and fetched #120

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Fix: InvalidArgumentError: conv2d_1_input_1:0 is both fed and fetched #120

merged 3 commits into from
Jul 12, 2018

Conversation

keisen
Copy link
Collaborator

@keisen keisen commented Jul 4, 2018

Hi, I created PullRequest so please refer to it.

Issue

If wrt_tensor is None, #119 occurs in TensorFlow 1.8.

Fix

Create wrt_tensor with keras.backend.identity to avoid errors.
However, gradient calculation uses input_tensor.

This was referenced Jul 5, 2018
Closed
Closed
@keisen
Improve wrt_tensor instance check.
74f2d08 
Support when wrt_tensor isn't None and input_tensor and wrt_tensor are the same instance.
keisen added a commit to keisen/keras-vis that referenced this pull request Jul 10, 2018
@keisen
Add: simple optimizer test for raghakot#120
a0fee9f
@keisen
Copy link
Collaborator Author

keisen commented Jul 10, 2018 •
edited
Loading

@raghakot .

I made this patch to FIX #119.
Since there is no change in the API specification, docstring isn't changed.
A simple unit test was added. However, unit tests have failed due to problems from before.

What else can I do to merge this patch into master branch?

Thanks!

raghakot
raghakot approved these changes Jul 12, 2018
View reviewed changes
Copy link
Owner

@raghakot raghakot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@raghakot raghakot merged commit 137f268 into raghakot:master Jul 12, 2018
@keisen keisen mentioned this pull request Aug 24, 2018
Closed
@soroushj soroushj mentioned this pull request Sep 1, 2018
Closed
@keisen keisen mentioned this pull request Oct 7, 2018
Closed
@keisen keisen deleted the bugfix/#119 branch October 22, 2018 06:38
@keisen keisen mentioned this pull request Nov 1, 2018
Closed
@thommiano thommiano mentioned this pull request Sep 25, 2019
Open
@keisen keisen mentioned this pull request Dec 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghakot raghakot raghakot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keisen @raghakot