Skip to content
This repository has been archived by the owner on Nov 8, 2017. It is now read-only.

NPE in CircularProgressView #5

Closed
luhmirin-s opened this issue Mar 26, 2015 · 8 comments
Closed

NPE in CircularProgressView #5

luhmirin-s opened this issue Mar 26, 2015 · 8 comments

Comments

@luhmirin-s
Copy link

Hi!

Two random crashes showed up in Crashlytics. Not sure in what circumstances and how to reproduce it. Never encountered myself. Just for your information, maybe there is something obviuos.

Devices: Sony ST26I (4.1.2) and LG-E460 (4.1.2)

java.lang.NullPointerException
       at android.view.GLES20Canvas.drawArc(GLES20Canvas.java:726)
       at com.github.rahatarmanahmed.cpv.CircularProgressView.onDraw(CircularProgressView.java:119)
       at android.view.View.draw(View.java:13573)
       at android.view.View.getDisplayList(View.java:12524)
       at android.view.View.getDisplayList(View.java:12568)
       at android.view.View.draw(View.java:13297)
       at android.view.ViewGroup.drawChild(ViewGroup.java:3037)
...

Thanks for awesome library.

@rahatarmanahmed
Copy link
Owner

Which version are you using?
On Mar 26, 2015 10:42 AM, "Sergejs Luhmirins" notifications@github.com
wrote:

Hi!

Two random crashes showed up in Crashlytics. Not sure in what
circumstances and how to reproduce it. Never encountered myself. Just for
your information, maybe there is something obviuos.

Devices: Sony ST26I (4.1.2) and LG-E460 (4.1.2)

java.lang.NullPointerException
at android.view.GLES20Canvas.drawArc(GLES20Canvas.java:726)
at com.github.rahatarmanahmed.cpv.CircularProgressView.onDraw(CircularProgressView.java:119)
at android.view.View.draw(View.java:13573)
at android.view.View.getDisplayList(View.java:12524)
at android.view.View.getDisplayList(View.java:12568)
at android.view.View.draw(View.java:13297)
at android.view.ViewGroup.drawChild(ViewGroup.java:3037)
...

Thanks for awesome library.


Reply to this email directly or view it on GitHub
#5.

@luhmirin-s
Copy link
Author

1.0.0 in production.

@rahatarmanahmed
Copy link
Owner

Sorry, I don't see an obvious reason why it would drop an NPE like that. Does it happen instantly or maybe after switching into the application?

@luhmirin-s
Copy link
Author

As I stated before, that stacktrace is from Crashlytics, I have never encountered this crash myself. I will investigate a bit and update if I find some new details.

@luhmirin-s
Copy link
Author

I managed to reproduce it. NPE happens when I open and close and close activity with progress view very fast.

@rahatarmanahmed
Copy link
Owner

I made some changes that may prevent the NPE, can you try forking from my
latest commit and seeing if the problem persists?
On Mar 27, 2015 10:24 AM, "Sergejs Luhmirins" notifications@github.com
wrote:

I managed to reproduce it. NPE happens when I open and close and close
activity with progress view very fast.


Reply to this email directly or view it on GitHub
#5 (comment)
.

@luhmirin-s
Copy link
Author

Well, I am not able to reproduce it in test project (It may be different in actual project), so lets assume its fixed and if something shows up, I will make a pull request.

@rahatarmanahmed
Copy link
Owner

Pushed those changes to v2.0.1. Feel free to update your dependency to that
tomorrow. For now, I will close this issue.

On Fri, Mar 27, 2015 at 2:57 PM, Sergejs Luhmirins <notifications@github.com

wrote:

Well, I am not able to reproduce it in test project (It may be different
in actual project), so lets assume its fixed and if something shows up, I
will make a pull request.


Reply to this email directly or view it on GitHub
#5 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants